fix: issue where repr on test accounts manager was misleading #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Aug 16, 2022
NotPeopling2day
previously approved these changes
Aug 16, 2022
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
antazoey
dismissed stale reviews from NotPeopling2day and fubuloubu
via
178dbf4
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
fubuloubu
approved these changes
Aug 16, 2022
antazoey
added a commit
to sabotagebeats/ape
that referenced
this pull request
Aug 17, 2022
sabotagebeats
added a commit
that referenced
this pull request
Aug 17, 2022
* feat: compiler settings * refactor: resolving @unparalleled-js comments * chore: linting * refactor: more performant return statement Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> * refactor: moved compiler_data * docs: Update src/ape/api/compiler.py * docs: Update src/ape/api/compiler.py * fix: update copy_on_model_validation expected value (#982) * fix: issue where repr on test accounts manager was misleading (#981) Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: Juliya Smith <yingthi@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Was pointed out that if you do
in console, the repr shows as an empty list even though it isn't.
This PR fixes that as well as adds an accounts guide.
How I did it
Override repr to show addresses of test accounts.
How to verify it
Checklist