rstrip version string, fixes windows 0.5.x bug

ApeWorX · Jul 26, 2019 · c80069b · c80069b
1 parent d04205d
commit c80069b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/solcx/main.py b/solcx/main.py
@@ -42,7 +42,7 @@ def get_solc_version_string(**kwargs):
             stderr_data=stderrdata,
             message="Unable to extract version string from command output",
         )
-    return version_string
+    return version_string.rstrip()
 
 
 def get_solc_version(**kwargs):

diff --git a/tests-old/core/utility/test_solc_version.py b/tests-old/core/utility/test_solc_version.py
diff --git a/tests/test_solc_version.py b/tests/test_solc_version.py
@@ -0,0 +1,13 @@
+import solcx
+
+import semantic_version
+
+
+def test_get_solc_version(all_versions):
+    version = solcx.get_solc_version()
+    assert isinstance(version, semantic_version.Version)
+
+
+def test_get_solc_version_string(all_versions):
+    version = solcx.get_solc_version_string()
+    assert isinstance(version, str)