Skip to content

Commit

Permalink
iox-eclipse-iceoryx#337 Remove iox::posix::Timer
Browse files Browse the repository at this point in the history
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
  • Loading branch information
FerdinandSpitzschnueffler committed May 30, 2022
1 parent ce99af6 commit 93ab230
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 1,404 deletions.
1 change: 1 addition & 0 deletions doc/website/release-notes/iceoryx-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
- Builder pattern extracted from `helplets.hpp` into `design_pattern/builder.hpp`
- Uninteresting mock function calls in tests [\#1341](https://github.com/eclipse-iceoryx/iceoryx/issues/1341)
- `cxx::unique_ptr` owns deleter, remove all deleter classes [\#1143](https://github.com/eclipse-iceoryx/iceoryx/issues/1143)
- Remove `iox::posix::Timer` [\#337](https://github.com/eclipse-iceoryx/iceoryx/issues/337)

**New API features:**

Expand Down
1 change: 0 additions & 1 deletion iceoryx_hoofs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ add_library(iceoryx_hoofs
source/posix_wrapper/signal_watcher.cpp
source/posix_wrapper/system_configuration.cpp
source/posix_wrapper/thread.cpp
source/posix_wrapper/timer.cpp
source/posix_wrapper/unnamed_semaphore.cpp
source/posix_wrapper/unix_domain_socket.cpp
source/relocatable_pointer/base_relative_pointer.cpp
Expand Down
5 changes: 3 additions & 2 deletions iceoryx_hoofs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,19 +155,20 @@ abstractions or add a new one when using POSIX resources like semaphores, shared
|`SharedMemoryObject` | i | | Creates and maps existing shared memory into the application. |
|`system_configuration` | i | | Collection of free functions which acquire system information like the page-size. |
|`thread` | | | Wrapper for pthread functions like `pthread_setname_np`. |
|`Timer` | | X | Interface for the posix timer, see [ManPage timer_create](https://www.man7.org/linux/man-pages/man2/timer_create.2.html). |
|`UnixDomainSocket` | i | | Interface for unix domain sockets. |

### Units

Never use physical properties like speed or time directly as integer or float in your code.
Otherwise you encounter problems like this function `void setTimeout(int timeout)`. What is the unit of the argument, seconds? minutes? If you use `Duration` you see it directly in the code.

```
```cpp

void setTimeout(const Duration & timeout);

setTimeout(11_s); // 11 seconds
setTimeout(5_ms); // 5 milliseconds

```
| class | internal | maybe obsolete | description |
Expand Down
323 changes: 0 additions & 323 deletions iceoryx_hoofs/include/iceoryx_hoofs/posix_wrapper/timer.hpp

This file was deleted.

0 comments on commit 93ab230

Please sign in to comment.