Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema-cache): ERCache.configureFaultTolerantRefresh #3807 #3823

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

gr8routdoors
Copy link
Contributor

Adds the notion of a fault tolerance in refresh for production environments where it's better to use a stale cache value than die when a cache entry refresh fails. See issue #3807 for details.

Note, this is a port of #3809 to the 2.5.x branch, since 2.4.x is frozen.

Adds the notion of a fault tolerance in refresh for production environments where it's better to use a stale cache value than die when a cache entry refresh fails.  See issue Apicurio#3807 for details.
@apicurio-bot
Copy link

apicurio-bot bot commented Oct 16, 2023

Thank you for creating a pull request!

Pinging @EricWittmann to respond or triage.

@carlesarnal carlesarnal merged commit 5ccf903 into Apicurio:2.5.x Oct 17, 2023
14 checks passed
gr8routdoors added a commit to gr8routdoors/apicurio-registry that referenced this pull request Oct 17, 2023
… (Apicurio#3823)

Adds the notion of a fault tolerance in refresh for production environments where it's better to use a stale cache value than die when a cache entry refresh fails.  See issue Apicurio#3807 for details.

Co-authored-by: Devon Berry <devon.berry@riotgames.com>
carlesarnal pushed a commit that referenced this pull request Oct 20, 2023
…a updates (#3839)

* feat(schema-cache): ERCache.configureFaultTolerantRefresh #3807 (#3823)

Adds the notion of a fault tolerance in refresh for production environments where it's better to use a stale cache value than die when a cache entry refresh fails.  See issue #3807 for details.

Co-authored-by: Devon Berry <devon.berry@riotgames.com>

* fix(schema-resolver): caching of latest artifacts #3834

Caching of artifacts with no version (e.g. latest) did not work because reindex would use the new key that has the artifact version that was found in the lookup.  This code changes the default behavior to index both the artifact with its version and the latest/null version.  It also exposes a configuration property (`apicurio.registry.cache-latest`) where this behavior can be disabled for use cases where caching of latest is not desired.  See #3824 for details.

---------

Co-authored-by: Devon Berry <devon.berry@riotgames.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants