fix(schema-resolver): caching of latest artifacts #3834 #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching of artifacts with no version (e.g. latest) did not work because reindex would use the new key that has the artifact version that was found in the lookup. This code changes the default behavior to index both the artifact with its version and the latest/null version. It also exposes a configuration property (`apicurio.registry.cache-latest`) where this behavior can be disabled for use cases where caching of latest is not desired. See Apicurio#3824 for details.
|
Thank you for creating a pull request! Pinging @carlesarnal to respond or triage. |
|
Note that I took the liberty of changing the default behavior to cache latest/null version artifacts. I think this is possibly the only contentious part of this PR. |
|
Looks like an unrelated intermittent failure with the node app package task causing the red build. I've seen this a couple times locally when doing full builds, but haven't looked into the root cause yet. It usually just works by continuing from where it failed. |
|
@gr8routdoors apparently there were some npm issues this afternoon (I dealt with them in another PR). Re-running the job so we have a full green build. Tomorrow I'll take a look at the full PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching of artifacts with no version (e.g. latest) did not work because reindex would use the new key that has the artifact version that was found in the lookup. This code changes the default behavior to index both the artifact with its version and the latest/null version. It also exposes a configuration property (
apicurio.registry.cache-latest) where this behavior can be disabled for use cases where caching of latest is not desired. See #3824 for details.