Add <!DOCTYPE html> to index #38
Labels
Comments
|
Which CSS breaks? |
|
Seeing it yourself is probably easier than describing (just paste the doctype at the top of index.html)
Seemingly several bits break - it seems to be an interaction with `.cards-pf` which is overriding the background colours for every element.
If you force an override with `body { background: #363636 !important }` you see the expected patterns (nice colour!). But obviously not a proper fix.
I’m still not completely familiar with the CSS debugger; been trying to trace the culprit more accurately.
… On 16 Feb 2017, at 12:36, Eric Wittmann ***@***.***> wrote:
Which CSS breaks?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZ2Wc_8ugZns1neAqP1LdQn_3VEj_u7ks5rdEK7gaJpZM4MC08E>.
|
|
I don't see any problems with background colors when I switch to standards mode. With the exception of the login screen, which does break. However, there ARE some problems that I do see. Fortunately all the work I did on the static mockups were using standards mode. So there shouldn't be TOO many issues since I mostly just copied that markup over when doing the angular2 impl. |
|
Oh, indeed, I was mainly talking about the logon screen.
… On 16 Feb 2017, at 13:12, Eric Wittmann ***@***.***> wrote:
I don't see any problems with background colors when I switch to standards mode. With the exception of the login screen, which does break.
However, there ARE some problems that I do see. Fortunately all the work I did on the static mockups were using standards mode. So there shouldn't be TOO many issues since I mostly just copied that markup over when doing the angular2 impl.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZ2WRUA5SRZiVRbnZnjzktISQUuHa78ks5rdEswgaJpZM4MC08E>.
|
EricWittmann
added a commit
that referenced
this issue
Feb 17, 2017
…mode, then fixed up minor visual/layout issues that resulted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently it's running in quirks mode, and when standards mode is enabled the CSS breaks.
The text was updated successfully, but these errors were encountered: