-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back-end Challenge - Finalizado #127
Open
luispaiva
wants to merge
13
commits into
Apiki:master
Choose a base branch
from
luispaiva:luis-paiva
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rquivo principal.
Ei *Luis*, bom dia!
Acuso o recebimento e agradeço o retorno. Já encaminhei seu desafio para
validação. Previsão retorno: quarta-feira. Faço novo contato para lhe
informar sobre o resultado.
Ótima semana :)
Em sáb., 9 de jul. de 2022 às 18:18, Luis Paiva ***@***.***>
escreveu:
… Boa noite.
Foi concluído o desenvolvimento para cumprir o desafio de back-end da
Apiki.
Foi alterado as instruções de execução no README para atender a execução
por parte do serviror embutido do PHP.
O código está dentro do padrão do PHPCS e todos os testes passam.
------------------------------
You can view, comment on, or merge this pull request online at:
#127
Commit Summary
- 774bb9b
<774bb9b>
Adição do Slim Framework para criação de rotas.
- 6224d29
<6224d29>
Implementação de rotas relacionadas a conversão de moeda.
- 58c1196
<58c1196>
Alteração da URL para compatibilidade do servidor embutido do PHP.
- 7b821ec
<7b821ec>
Criação do controller que converte os valores e as moedas.
- b843989
<b843989>
Criação do helper de validação de argumentos passados pela URL.
- 7b23b37
<7b23b37>
Alteração do namespace do controlador nas rotas.
- 3c16a3f
<3c16a3f>
Adição do arquivo .htaccess para enviar todas as requisições para o arquivo
principal.
- cfd8068
<cfd8068>
Alterado link do repositório na documentação.
- c86ab7f
<c86ab7f>
Inserção de atributos para facilitar manutenção.
- 3a407f6
<3a407f6>
Configurações de arquivos para utilização do padrão pela IDE.
- 6839d48
<6839d48>
Alteração de nomenclatura para validação de padrão.
- 11ab882
<11ab882>
Alteração de nomenclatura de método para validação de padrão.
- 2d77cde
<2d77cde>
Alterado o readme com instruções para realizar os testes do desafio.
File Changes
(10 files <https://github.com/Apiki/back-end-challenge/pull/127/files>)
- *A* .htaccess
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-270939b4fba4be968ab78e23dc0207eb893744491980a25c99a27c809a82ddab>
(4)
- *A* .vscode/settings.json
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357>
(24)
- *M* README.md
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(57)
- *M* codeception.yml
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-fd9d2a49391d351f7eff29cf7f4d1e876722ecb0130cdc3d0e7ed49e0f03b587>
(2)
- *M* composer.json
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34>
(3)
- *M* composer.lock
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5>
(455)
- *M* index.php
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-7413d6453f901e939bbd840c8f0d1c7b20c2ca0e7f71741e4e07c6cf036f16c0>
(14)
- *A* phpcs.xml
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-daa856500eea114bbf034fd35b7600050d965e5d19bb0700885c075747848fd8>
(7)
- *A* src/Controllers/Exchange.php
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-5ff9c885d1289b38a68ecf375720b2ce954fd6b48dd3c679e5f85e0d4f21017a>
(80)
- *A* src/Helpers/Validate.php
<https://github.com/Apiki/back-end-challenge/pull/127/files#diff-c8c34a75ce9ac33f01bacbdb09e8042d69e2eee7abac239ad11d930f047d4ff9>
(120)
Patch Links:
- https://github.com/Apiki/back-end-challenge/pull/127.patch
- https://github.com/Apiki/back-end-challenge/pull/127.diff
—
Reply to this email directly, view it on GitHub
<#127>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXLSFSBYTDJ6P6PVYVT5O53VTHUDFANCNFSM53D6ECVQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boa noite.
Foi concluído o desenvolvimento para cumprir o desafio de back-end da Apiki.
Foi alterado as instruções de execução no README para atender a execução por parte do serviror embutido do PHP.
O código está dentro do padrão do PHPCS e todos os testes passam.