New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest JavaScriptKit #8
Conversation
(enums containing objects and primitives) JavaScriptKit a87af4e
Hi @Unkaputtbar, @PSchmiedmayer, would you be able to have a look at this PR at some point? Otherwise, if you need any help in maintaining the project, please let me know. The SwiftWasm team would be happy to help, as it became quite important for us while developing DOMKit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay. I am pretty busy with other stuff right now.
I had a look at your changes and think they are fine in general.
I will talk to @PSchmiedmayer to see if we can get one of you merge rights, too.
It's cool that you are using the stuff we built.
Sources/WebIDL/IntermediateRepresentation/Member Nodes/MethodNode.swift
Outdated
Show resolved
Hide resolved
Hi @j-f1 @MaxDesiatov, |
Fantastic, I very much appreciate it! |
Sources/WebIDL/IntermediateRepresentation/Member Nodes/MethodNode.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK if void
to undefined
change was really needed (maybe needs an explanatory comment at case unknown
or some other better suited location?), but other than line length nitpicks this seems legit.
…ode.swift Co-authored-by: Max Desiatov <max@desiatov.com>
They changed the WebIDL spec from using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pending the merger of swiftwasm/JavaScriptKit#26, everything needed for the output of
webidl2swift
to work will be included in the shipping version of JavaScriptKit! I made several changes to align the APIs and fixed a bug where callback protocols could not be passed as a function.