-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched login flow to code authorization #71
Conversation
Cool, thank you. Is also the token refresh working? |
As I understand both methods are working at the moment. Could it be better to let choose the method by a switch? |
All good this was not the question. It was about if the token refresh mechanismus is still working also when doing a new login with this method? |
As this method returns a refresh_token, I believe the refresh is just the same. I'll test some more tonight. Please review the code, especially the parts deleted... I didn't quite understand all the callback stuff ;) |
Will also try to find time tonight |
access_token refresh works:
I don't quite understand what the access_token is used for. I can always use the refresh_token to retrieve the cookies:
Note: no cookies were required when making the request! That leaves the renewal of the refresh_token... unless it never expires. |
Thnak you for checking! |
Changes make sense ... thank you, I will merge now and release as new version next days |
@adn77 BTW I made the refresh flow working with both in the end ... lets see how it goes midterm. I'm not that sure that code-verieir and auth.code is working "long time" |
I adapted the login flow based on recent proxy intercepts and this:
mkb79/Audible#41
Fyi, I have zero knowledge of modern JS so please be gentle with any critism :D