Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout and retry to got requests #19

Merged
merged 8 commits into from
Nov 29, 2021
Merged

Added timeout and retry to got requests #19

merged 8 commits into from
Nov 29, 2021

Conversation

DrHauss
Copy link
Contributor

@DrHauss DrHauss commented Aug 18, 2021

I have received some timeouts on different stages where the default timeout of 3500ms is not enough. So I added retry and timeout to each got request in the login function via e-mail+password.

Hauss, Christian added 3 commits August 18, 2021 14:03
index.js - Added timeout to got requests
- Added retry to all got requests when login with username and password
@Apollon77
Copy link
Owner

Thank you for your contribution. Could you change it that it is confígurable via the "options object" in the main constructor. I'm completely fine with your values as defaults. I would see two settings. one for the "communicationTimeout" value (10000 nd then use in all places) and one for the "communicationRetries"

@Apollon77 Apollon77 self-requested a review August 19, 2021 19:49
Copy link
Owner

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see last comment, please make sthe values configurable via options object

@DrHauss
Copy link
Contributor Author

DrHauss commented Aug 20, 2021

Thank you for your contribution. Could you change it that it is confígurable via the "options object" in the main constructor. I'm completely fine with your values as defaults. I would see two settings. one for the "communicationTimeout" value (10000 nd then use in all places) and one for the "communicationRetries"

I added both options and enhanced the timeout and retries also within the openid client requests.

@Apollon77
Copy link
Owner

Cool, thank you, will review tonight

@ThibautTrarbach
Copy link

Hello, do you have any news?

@Apollon77
Copy link
Owner

Ohh, lost completely from radar ... sorry ... comes soon. Thanks for the reminder

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants