-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout and retry to got requests #19
Conversation
index.js - Added timeout to got requests
- Added retry to all got requests when login with username and password
Thank you for your contribution. Could you change it that it is confígurable via the "options object" in the main constructor. I'm completely fine with your values as defaults. I would see two settings. one for the "communicationTimeout" value (10000 nd then use in all places) and one for the "communicationRetries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see last comment, please make sthe values configurable via options object
…onRetries is set. - Fixed spelling in descriptions.
I added both options and enhanced the timeout and retries also within the openid client requests. |
Cool, thank you, will review tonight |
Hello, do you have any news? |
Ohh, lost completely from radar ... sorry ... comes soon. Thanks for the reminder |
I have received some timeouts on different stages where the default timeout of 3500ms is not enough. So I added retry and timeout to each got request in the login function via e-mail+password.