Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: onPlay, onPause, and onEnd side effects for the media player (#…
…2418) * add triggers for onPlay, onPause, and onEnd to an effect instead of trying to run as a side effect in the useCallback functions * update the video player storybook story to use the new events * fix linter? * remove the onEnd logic from the effect in Container - instead pass onEnd to video components themselves to trigger it * use analyticsMeta instead of sessionId directly * remove console.logs * fix typescript issues * make onEnd required, I think. typescript is new to me, can't you tell? ;) Co-authored-by: Vincent Wilson <vince@classyh.at>
- Loading branch information
1 parent
78241bb
commit 09f9ffa
Showing
6 changed files
with
72 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters