Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update out-of-date samples #853

Closed
martincostello opened this issue May 6, 2021 · 1 comment
Closed

Update out-of-date samples #853

martincostello opened this issue May 6, 2021 · 1 comment

Comments

@martincostello
Copy link
Member

As reported in #852 (comment), some of the examples in the wiki are out-of-date for Polly v7.

These examples are outdated and the wiki also points to this outdated issue (https://github.com/App-vNext/Polly/wiki/Retry#retryafter-when-the-response-specifies-how-long-to-wait).

I was hoping that that applying WaitAndRetryAsync on the PolicyBuilder would still work in 7.2.2, but the return type is now AsyncRetryPolicy.

A quick excerpt from #414 that doesn't work anymore:

var _retryAfterPolicy = Policy .HandleResult(r => r?.Headers?.RetryAfter != null) .WaitAndRetryAsync( retryCount: numRetries, sleepDurationProvider: (retryCount, response, context) => getServerWaitDuration(response) );

If you can update the wiki to point to the new overload and to a more recent working example, it would be greatly helpful!

We should go through the wiki and update any out-of-date examples found with up-to-date equivalents.

@martincostello
Copy link
Member Author

Superseded by #1091.

@martincostello martincostello closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
@martincostello martincostello removed the help wanted A change up for grabs for contributions from the community label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant