Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make bars rounded in bar chart #108

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add option to make bars rounded in bar chart #108

merged 1 commit into from
Feb 28, 2023

Conversation

mklkj
Copy link

@mklkj mklkj commented Feb 28, 2023

Based on work from WW-Digital#4

Standard Rounded

@@ -133,7 +150,11 @@ protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {
mBarShadowRectBuffer.top = mViewPortHandler.contentTop();
mBarShadowRectBuffer.bottom = mViewPortHandler.contentBottom();

c.drawRect(mBarShadowRectBuffer, mShadowPaint);
if (mDrawRoundedBars) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to your work, but I guess your intention is not perfect

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@hannesa2 hannesa2 merged commit c0ee877 into AppDevNext:master Feb 28, 2023
@mklkj mklkj deleted the feature/bar-chart-rounded branch February 28, 2023 14:09
@hannesa2 hannesa2 added the enhancement New feature or request label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants