fix: text update bug on number/url fields (#5315)

AppFlowy-IO · May 13, 2024 · 027ab2c · 027ab2c
1 parent 8273d66
commit 027ab2c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/...appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart b/...appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart
@@ -163,19 +163,18 @@ class _TextCellState extends State<TextCardCell> {
     return BlocBuilder<TextCellBloc, TextCellState>(
       builder: (context, state) {
         final content = state.content;
-        final text = content.isEmpty
-            ? LocaleKeys.grid_row_textPlaceholder.tr()
-            : content;
-        final color = content.isEmpty ? Theme.of(context).hintColor : null;
-
-        return Padding(
-          padding: widget.style.padding,
-          child: Text(
-            text,
-            style: widget.style.textStyle.copyWith(color: color),
-            maxLines: widget.style.maxLines,
-          ),
-        );
+
+        return content.isEmpty
+            ? const SizedBox.shrink()
+            : Container(
+                padding: widget.style.padding,
+                alignment: AlignmentDirectional.centerStart,
+                child: Text(
+                  content,
+                  style: widget.style.textStyle,
+                  maxLines: widget.style.maxLines,
+                ),
+              );
       },
     );
   }

diff --git a/...end/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/number.dart b/...end/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/number.dart
@@ -79,8 +79,11 @@ class _NumberCellState extends GridEditableTextCell<EditableNumberCell> {
     return BlocProvider.value(
       value: cellBloc,
       child: BlocListener<NumberCellBloc, NumberCellState>(
-        listener: (context, state) =>
-            _textEditingController.text = state.content,
+        listener: (context, state) {
+          if (!focusNode.hasFocus) {
+            _textEditingController.text = state.content;
+          }
+        },
         child: Builder(
           builder: (context) {
             return widget.skin.build(

diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart
@@ -112,8 +112,10 @@ class _GridURLCellState extends GridEditableTextCell<EditableURLCell> {
       child: BlocListener<URLCellBloc, URLCellState>(
         listenWhen: (previous, current) => previous.content != current.content,
         listener: (context, state) {
-          _textEditingController.value =
-              _textEditingController.value.copyWith(text: state.content);
+          if (!focusNode.hasFocus) {
+            _textEditingController.value =
+                _textEditingController.value.copyWith(text: state.content);
+          }
           widget._cellDataNotifier.value = state.content;
         },
         child: widget.skin.build(