Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appflowy_flutter): Flutter Version Reset Error #1923

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

AmanNegi
Copy link
Contributor

@AmanNegi AmanNegi commented Mar 4, 2023

  • flutter channel stable was causing the FlutterSDK to upgrade to its latest version.
  • Added code to fix this behavior.
  • Tested on Windows and Linux.

Issue: #1912

- `flutter channel stable` was causing the FlutterSDK to upgrade to it's
latest version.
- Added code to fix this behaviour.
- Tested on Windows and Linux.
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 6, 2023

Hi, @AmanNegi.

The option -P is invalid on macOS.

AppFlowy : Setting up Flutter
grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
	[-e pattern] [-f file] [--binary-files=value] [--color=when]
	[--context[=num]] [--directories=action] [--label] [--line-buffered]
	[--null] [pattern] [file ...]
Unhandled exception:

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 7, 2023

Hey @LucasXu0, I have fixed the issue. Could you please test it now, I don't have any MacOS device so I can't test sorry 😢.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 7, 2023

Okay. Let me try it.

- Replace `-P` with `-E` which should now work as expected in Mac devices.
- Fixed Commit Structure
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 8, 2023

Hey, @AmanNegi. The script will complain as the below pic shows if the developer uses the other version of Flutter. Because the script switches to the Flutter path but doesn't switch back.

Screenshot 2023-03-08 at 14 08 38

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 8, 2023

Yep, thanks for pointing that out! I will fix that behavior.

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 9, 2023

image

@LucasXu0 getting this weird error, any idea why this could be happening? I only made changes to the .sh files. It can't find the gitlint present in .githooks.

Now we move back to cwd after making changes
@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 13, 2023

@LucasXu0 Could you please check if the changes I made, fixes the issue that we were facing?

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 14, 2023

Hi, @AmanNegi. LGTM. And I changed the text format from CTLF to LF.

@LucasXu0 LucasXu0 merged commit caffb9f into AppFlowy-IO:main Mar 16, 2023
@AmanNegi AmanNegi deleted the fix-flutter-version-reset branch March 16, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants