feat: insert emoji using ":" command #3025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3025 +/- ##
===========================================
- Coverage 68.70% 13.00% -55.71%
===========================================
Files 426 432 +6
Lines 20241 20665 +424
===========================================
- Hits 13907 2687 -11220
- Misses 6334 17978 +11644
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Xazin
reviewed
Jul 19, 2023
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Jul 19, 2023
...er/lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_picker_builder.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Jul 19, 2023
...er/lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_picker_builder.dart
Outdated
Show resolved
Hide resolved
Xazin
reviewed
Jul 19, 2023
...er/lib/plugins/document/presentation/editor_plugins/emoji_shortcut/emoji_picker_builder.dart
Outdated
Show resolved
Hide resolved
|
@Xazin I made the suggested changes |
Xazin
reviewed
Jul 19, 2023
Comment on lines
101
to
103
| for (int i = 0; i < _emojiController.text.length + 1; i++) { | ||
| _deleteLastCharacters(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < _emojiController.text.length + 1; i++) { | |
| _deleteLastCharacters(); | |
| } | |
| _deleteLastCharacters(_emojiController.text.length); |
LucasXu0
reviewed
Jul 19, 2023
| @@ -8,6 +8,8 @@ import 'package:flowy_infra_ui/flowy_infra_ui.dart'; | |||
| import 'package:flutter/material.dart'; | |||
| import 'package:flutter_bloc/flutter_bloc.dart'; | |||
|
|
|||
| import 'editor_plugins/emoji_shortcut/emoji_shortcut_service.dart'; | |||
There was a problem hiding this comment.
Move this header to editor_plugins/plugins.dart.
| ShortcutEmojiPickerViewState createState() => ShortcutEmojiPickerViewState(); | ||
| } | ||
|
|
||
| @visibleForTesting |
There was a problem hiding this comment.
no need to add @visibleForTesting
| @@ -0,0 +1,92 @@ | |||
| import 'package:appflowy_backend/protobuf/flowy-folder2/protobuf.dart'; | |||
There was a problem hiding this comment.
This test will not be executed in the CI job. Please add this test to document_test_runner.dart.
| final resultsFilterCount = 35; | ||
|
|
||
| @override | ||
| void initState() { |
There was a problem hiding this comment.
call the super.initState(); at the beginning.
There was a problem hiding this comment.
@override
void initState() {
super.initState();
final initCategory = widget.state.categoryEmoji.indexWhere(
(element) => element.category == widget.config.initCategory,
);
final initialIndex = initCategory != -1 ? initCategory : 0;
_tabController = TabController(
initialIndex: initialIndex,
length: widget.state.categoryEmoji.length,
vsync: this,
);
_pageController = PageController(
initialPage: initialIndex,
);
_emojiFocusNode.requestFocus();
WidgetsBinding.instance.addPostFrameCallback((_) {
_focusNode.requestFocus();
});
}| super.dispose(); | ||
| } | ||
|
|
||
| bool get isEmojiSearching => |
There was a problem hiding this comment.
Move this getter before the initState function.
| searchEmojiList.emoji.isNotEmpty || _emojiController.text.isNotEmpty; | ||
|
|
||
| KeyEventResult _onKey(FocusNode node, RawKeyEvent event) { | ||
| final CategoryEmoji catEmoji = isEmojiSearching |
There was a problem hiding this comment.
no need to declare the type. remove the CategoryEmoji.
| } else if (event.logicalKey == LogicalKeyboardKey.arrowUp) { | ||
| newSelectedIndex -= 7; | ||
| } else if (event.logicalKey == LogicalKeyboardKey.arrowDown) { | ||
| newSelectedIndex += 7; |
There was a problem hiding this comment.
why using 7? Please make it configurable.
| return KeyEventResult.ignored; | ||
| } | ||
|
|
||
| _searchEmoji() { |
| widget.editorState.apply(transaction); | ||
| } | ||
|
|
||
| void _insertText(String text) { |
There was a problem hiding this comment.
remove this function. use widget.editorState.insertTextAtCurrentSelection(text); instead
|
…m/rizwan3395/AppFlowy into use_character_shortcut_for_emojis
|
Could this plugin be considered an editor one or AppFlowy specific? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
AppFlowy_o9xHZRPzJ9.mp4
PR Checklist
This PR fixes issue #2797