Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed padding values and added borderRadius #567

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

Kritarthsharma
Copy link
Contributor

Fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3313

  • Modified the appflowy_editor package to implement the requested UI fix.
  • Changed the padding values and added borderRadius for more consistent look.
Screen.Recording.2023-10-30.at.5.58.17.PM.mov
Screenshot 2023-10-30 at 6 00 11 PM Screenshot 2023-10-30 at 5 59 42 PM

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023

CLA assistant check
All committers have signed the CLA.

@MayurSMahajan
Copy link
Contributor

Hey @Kritarthsharma,

actually, you were not supposed to add a border radius on the option, but the container which displays the options. Basically when there are no results the container has less border radius.

image

Also, I see that you are padding to the no-results text. Rather than applying padding to the No Results text, you can calculate the width of other options used in the Selection Menu and then use that fixed width with center-aligned text. See if that is possible.

@Kritarthsharma
Copy link
Contributor Author

Hi @MayurSMahajan, I've made changes as you suggested. Can you please review it?

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8368d8) 80.43% compared to head (6fb0f04) 80.43%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files         285      285           
  Lines       12194    12194           
=======================================
  Hits         9808     9808           
  Misses       2386     2386           
Files Coverage Δ
...c/editor/selection_menu/selection_menu_widget.dart 40.82% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 885ad91 into AppFlowy-IO:main Nov 6, 2023
10 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 13, 2023
* main:
  chore: refactor mobile toolbar and divider block component (AppFlowy-IO#583)
  fix: don't rebuild mobile toolbar everytime (AppFlowy-IO#579)
  chore: bump version 1.5.2 (AppFlowy-IO#578)
  fix: quit editing button doesn't work (AppFlowy-IO#577)
  chore: changed padding values and added borderRadius (AppFlowy-IO#567)
  fix: catch regex `FormatException` and show a corresponding error message  (AppFlowy-IO#573)
  fix: 'PageStorage.of' returns null (AppFlowy-IO#575)
  feat: Checkbox unresponsive in custom Theme example in editor example app (AppFlowy-IO#543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants