Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show placeholder override for paragraph block #571

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat: show placeholder override for paragraph block #571

merged 1 commit into from
Nov 2, 2023

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Nov 1, 2023

Closes: #564

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7ab33c0) 80.41% compared to head (b0aa4e7) 80.40%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   80.41%   80.40%   -0.02%     
==========================================
  Files         286      286              
  Lines       12178    12181       +3     
==========================================
+ Hits         9793     9794       +1     
- Misses       2385     2387       +2
Files Coverage Δ
...hortcut_events/format_double_characters/utils.dart 94.11% <ø> (-0.33%) ⬇️
...aph_block_component/paragraph_block_component.dart 96.00% <71.42%> (-2.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin Xazin merged commit 9b8d855 into AppFlowy-IO:main Nov 2, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 3, 2023
@q200892907
Merge branch 'main' into feat-zhiya
b45d999 
* main:
  fix: check if header exists for footer (AppFlowy-IO#559)
  feat: show placeholder override for paragraph block (AppFlowy-IO#571)
  chore: refactor character replacement (AppFlowy-IO#570)
  chore: rename shortcut folder (AppFlowy-IO#569)
  fix: image copy error width/height  is double (AppFlowy-IO#566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Override paragraph block showPlaceholder
1 participant
@Xazin