fix:Solve the left and right key bug. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… head or tail of the editor, it cannot be moved.
Closed
Xazin
approved these changes
Nov 9, 2023
Xazin
requested changes
Nov 9, 2023
| @@ -52,8 +51,7 @@ class KeyboardServiceWidgetState extends State<KeyboardServiceWidget> | |||
| return true; | |||
| }, | |||
| ); | |||
| editorState.service.selectionService | |||
| .registerGestureInterceptor(interceptor); | |||
| editorState.service.selectionService.registerGestureInterceptor(interceptor); | |||
There was a problem hiding this comment.
Seems like your formatting options are different than default 80 character line length.
|
@q200892907 The format step failed. PTAL. |
Restored default format |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 80.54% 80.51% -0.04%
==========================================
Files 286 286
Lines 12182 12232 +50
==========================================
+ Hits 9812 9848 +36
- Misses 2370 2384 +14 ☔ View full report in Codecov by Sentry. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Nov 15, 2023
* main: fix: solve the left and right key bug. (AppFlowy-IO#584) feat: toggle format on mobile (AppFlowy-IO#587) feat: support toggling format style when the selection is collapsed (AppFlowy-IO#586) chore: release 2.0.0-beta.1 (AppFlowy-IO#582) feat: support Flutter stable channel (AppFlowy-IO#581) # Conflicts: # lib/src/editor/editor_component/service/ime/non_delta_input_service.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the left and right key bug. When adding an input box at the head or tail of the editor, it cannot be moved.