Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:chinese input 610 #652

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix:chinese input 610 #652

merged 1 commit into from
Jan 9, 2024

Conversation

q200892907
Copy link
Contributor

@q200892907 q200892907 commented Jan 6, 2024

#610 test window/linux @LucasXu0

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7ec43c9) 78.31% compared to head (a9fb874) 76.79%.
Report is 4 commits behind head on main.

Files Patch % Lines
...rvice/ime/delta_input_on_non_text_update_impl.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   78.31%   76.79%   -1.52%     
==========================================
  Files         291      293       +2     
  Lines       12805    12967     +162     
==========================================
- Hits        10028     9958      -70     
- Misses       2777     3009     +232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jan 8, 2024

Have you tested it on Windows?

@q200892907
Copy link
Contributor Author

Have you tested it on Windows?

I have tested on Windows and it can be used, but the test is not comprehensive enough.

@q200892907
Copy link
Contributor Author

I don’t know what problem the Windows judgment added at that time was used to solve. You can do a test based on the problem at that time.

@q200892907
Copy link
Contributor Author

2024-01-09.09.46.19.mov

windows test video

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jan 9, 2024

@q200892907 Thanks for contributing.

@LucasXu0 LucasXu0 merged commit bdc0dc1 into AppFlowy-IO:main Jan 9, 2024
8 of 11 checks passed
@q200892907 q200892907 deleted the fix-610 branch January 12, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants