Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for breakline and divider #690

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

penkzhou
Copy link
Contributor

@penkzhou penkzhou commented Jan 25, 2024

  1. current convert method documentToHTML will transfer the empty line into empty p tag. This will make when render the markdown content into html ignore the empty p tag which will ignore all the break lines.
  2. add support for the divider tag. it will transfer divider into hr tag.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

@penkzhou Please include the tests.

@penkzhou
Copy link
Contributor Author

penkzhou commented Jan 25, 2024

@LucasXu0 just add the test for br tag.

@LucasXu0
Copy link
Collaborator

@penkzhou There're two tests failed.

@penkzhou
Copy link
Contributor Author

penkzhou commented Jan 26, 2024

@LucasXu0 has fixed the failed tests.

@penkzhou penkzhou changed the title add support for breakline fix: add support for breakline Jan 26, 2024
@penkzhou penkzhou changed the title fix: add support for breakline fix: add support for breakline and divider Jan 29, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d8147c) 76.46% compared to head (85835df) 76.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   76.46%   76.36%   -0.11%     
==========================================
  Files         295      296       +1     
  Lines       13309    13319      +10     
==========================================
- Hits        10177    10171       -6     
- Misses       3132     3148      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 2c5d5c7 into AppFlowy-IO:main Jan 30, 2024
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 31, 2024
* main:
  chore: bump version 2.3.1 (AppFlowy-IO#697)
  feat: add contentInsertionConfiguration to editor and text input service (AppFlowy-IO#691)
  fix: add support for breakline and divider (AppFlowy-IO#690)
  chore: translate commands (AppFlowy-IO#687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants