Get rid of the extra space from numbered list item #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucasXu0 - can you take a look this PR? Would love to merge it and send over more markdown fixes. |
Approved. I will merge it once all the ci jobs have passed. |
|
@lming Please check the CI results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 75.79% 75.79%
=======================================
Files 297 297
Lines 13761 13761
=======================================
Hits 10430 10430
Misses 3331 3331 ☔ View full report in Codecov by Sentry. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Mar 12, 2024
* main: feat: disable converting heading block to numbered list block (AppFlowy-IO#740) fix: xtra space from numbered list item (AppFlowy-IO#724) fIx: disable tableActionHandler when the editorState is not editable (AppFlowy-IO#733) feat: add fixed toolbar example (AppFlowy-IO#739) chore: bump version 2.3.3 (AppFlowy-IO#735) fix: transfer the whole line into link when text contains url (AppFlowy-IO#693) (AppFlowy-IO#737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra leading space from numbered list item is removed.