Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve mobile selection #776

Merged

Conversation

richardshiue
Copy link
Contributor

@richardshiue richardshiue commented Apr 20, 2024

Interaction Android iOS
tap
Screen.Recording.2024-04-20.at.9.46.46.PM.mov
Screen.Recording.2024-04-20.at.9.20.28.PM.mov
double tap
Screen.Recording.2024-04-20.at.9.47.13.PM.mov
Screen.Recording.2024-04-20.at.9.21.30.PM.mov
triple tap
Screen.Recording.2024-04-20.at.9.47.28.PM.mov
Screen.Recording.2024-04-20.at.9.22.09.PM.mov
long press + pan
Screen.Recording.2024-04-20.at.9.47.40.PM.mov
Screen.Recording.2024-04-20.at.9.21.01.PM.mov
regular pan
Screen.Recording.2024-04-20.at.9.58.21.PM.mov
N/A

Copy link
Contributor Author

@richardshiue richardshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it absolutely necessary to use updateSelection? Will a editorState.updateSelectionWithReason be good enough?

Copy link
Contributor Author

@richardshiue richardshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the collapsed handle for iOS on main or here, but I don't know why?

@LucasXu0
Copy link
Collaborator

Is it absolutely necessary to use updateSelection? Will a editorState.updateSelectionWithReason be good enough?

Using editorState.selection or editorState.updateSelectionWithReason are both OK.

I don't see the collapsed handle for iOS on main or here, but I don't know why?

In most cases, iOS does not feature a collapsed handle. iOS users can update a collapsed selection by long-pressing on it.

@richardshiue By the way, the word count service test failed.

@richardshiue
Copy link
Contributor Author

#771 introduced a change to the word counting regex. AppFlowy!AppFlowy should be counted as two words, not one. @Xazin I think this is a regression.

@LucasXu0 LucasXu0 merged commit 90260d3 into AppFlowy-IO:main Apr 26, 2024
2 of 10 checks passed
@richardshiue richardshiue deleted the chore/improve-floating-mobile-toolbar branch April 26, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants