Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bug - arrow problem 4764 #783

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Taverz
Copy link
Contributor

@Taverz Taverz commented Apr 25, 2024

This problem is related to the paragraph, since after the paragraph there is no line it has nowhere to go.I made it so that even within a paragraph you can move between lines. I did this so that you can disable this feature, and also fixed some things in the code.
AppFlowy-IO/AppFlowy#4764

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@Taverz Taverz changed the title [Bug] arrow problem #4764 Fix: Bug - arrow problem 4764 Apr 25, 2024
@Taverz
Copy link
Contributor Author

Taverz commented Apr 25, 2024

Oops, it seems I did something wrong, I would like to fix it and restart))
How to run Github Action for checks?

@LucasXu0
Copy link
Collaborator

Hi, @Taverz. You can run these commands locally.

  flutter --version
  flutter pub get
  flutter analyze .
  dart format --set-exit-if-changed .
  flutter test --coverage

@Taverz
Copy link
Contributor Author

Taverz commented Apr 26, 2024

Hi, @LucasXu0 .
What to do after I ran these commands and checked everything, what exactly do I need to do, I don’t know how to do it correctly. Tell me please

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Apr 26, 2024

@Taverz If all the tests and analyses are passed, then the GitHub CI won't complain.

What you should do is

  • Fix the format issues
  • Fix the failed tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants