Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update selection from the delta #788

Merged
merged 1 commit into from
May 4, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented May 3, 2024

In the common case, the cursor will be placed after the composing text. So there's no need to update the selection manually.

However, on Windows and for some IMEs, the cursor will be placed at the front of the composing text. So updating the selection from the deltas is sufficient.

@LucasXu0 LucasXu0 force-pushed the cjk_on_windows branch 2 times, most recently from 6623804 to 8a3f8b7 Compare May 3, 2024 15:22
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.84%. Comparing base (ffe4b08) to head (b9a7438).

Files Patch % Lines
...editor/editor_component/service/ime/text_diff.dart 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   74.86%   74.84%   -0.03%     
==========================================
  Files         300      300              
  Lines       14181    14186       +5     
==========================================
  Hits        10617    10617              
- Misses       3564     3569       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit d9e6178 into AppFlowy-IO:main May 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants