Support the mobile platforms (iOS and Android) and make the editor more extensible. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: move selectionRects to editorState * chore: delete unused attributeKey font * feat: refactor showLinkMenu and LinkMenu * feat: replace old linkMenu * feat: add text color toolbar item - separate text color and highlight color item in toolbar - renaming in BuiltInAttributeKey(color -> textColor, backgroundColor -> highlightColor) - add text color and highlight color attribute in example.json - add icons for text color and highlight color in the toolbar * feat: add highlight color item in toolbar - add clear highlight color button - add onDismiss in ColorPicker to remove the overlay after remove highlight color * chore: delete old ColorPicker * test: migrate link menu test * chore: remove editorStyle from color menu and color picker * test: add color picker test * feat: remove editor style from link menu - add utils function and widgets for overlay - organize utils folder - add constant text into AppFlowyEditorLocalizations - improve pop up menu style * feat: add show link menu command shortcut - refactor CommandShortcutEventHandler - update related callback * feat: add showTextColorMenuCommand and showHighlightColorMenuCommand * fix: fix merge error in example.json * refactor: reorganize the file hierarchy * refactor: migrate format_style_handler_test.dart - delete format_style_handler_test.dart - migrate to markdown_commands_test.dart - move highlight test outside of markdown_commands_test * feat: delete show menu type command shortcut and their tooltip * fix: fix tooltip text * chore: delete context from CommandShortcutEventHandler * feat: add command shortcut for link menu * test: add show link menu command test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is currently unstable and is not ready for review. I submit this PR for syncing the context. Any suggestions regarding the architecture are appreciated.
Related to #97