Expose the original $CWD as an environment variable #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion, please rename to |
The place from where the appImage is executed might not be the same location where its placed. Consider an appImage located in `/opt/myapp.AppImage`. If I call such appImage from a terminal emulator where my `$CWD` is `/home/jviotti` (e.g: by passing the absolute path to the appImage), the application has no way to determine that it was run from `/home/jviotti`. This is very useful to provide a better integration when your application is executed from a terminal emulator. Classic GNU/Linux applications, like GIMP, set the default location of file dialogs to the place where the `gimp` command was executed from. In order to expose this to the user, we set the `OWD` environment to the result of `getcwd()` right before the runtime passes control to `AppRun`. Fixes: #172 Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
|
Renamed! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The place from where the appImage is executed might not be the same
location where its placed.
Consider an appImage located in
/opt/myapp.AppImage. If I call suchappImage from a terminal emulator where my
$CWDis/home/jviotti(e.g: by passing the absolute path to the appImage), the application has
no way to determine that it was run from
/home/jviotti.This is very useful to provide a better integration when your
application is executed from a terminal emulator. Classic GNU/Linux
applications, like GIMP, set the default location of file dialogs to the
place where the
gimpcommand was executed from.In order to expose this to the user, we set the
OWDenvironment tothe result of
getcwd()right before the runtime passes control toAppRun.Fixes: #172
Signed-off-by: Juan Cruz Viotti jviottidc@gmail.com