Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root authentication added #364

Closed
wants to merge 13 commits into from
Closed

Root authentication added #364

wants to merge 13 commits into from

Conversation

abhay44
Copy link

@abhay44 abhay44 commented Feb 26, 2017

@probonopd added root authentication for appimageupdategui. Password will be asked when you run the executable as mentioned in the build.sh and I added README.md.So,it will be easy for users to understand how to build and execute.

@abhay44 abhay44 changed the title Master Root authentication added Feb 26, 2017
@probonopd
Copy link
Member

Thanks @abhay44 very good progess. However please consider that we cannot write to /usr/share/polkit-1/actions. AppImages are supposed to be self-contained, and must not install things into the system. Do you still see a way to make this work?

@abhay44
Copy link
Author

abhay44 commented Feb 26, 2017

As we are running pkexec and without com.appimageupdate.policy we can't run a graphical interface running on.We have to move the com.appimageupdate.policy to /usr/share/polkit-1/actions inorder to do so.Do you have any other ideas?

@probonopd
Copy link
Member

Normal users can't write to /usr so we need to ask the PolicyKit people what to do here. The Etcher AppImage seems to be able to become root without such trickery?

@abhay44
Copy link
Author

abhay44 commented Feb 27, 2017

@probonopd I added authentication as you said. No copying of files to /usr/share/polkit-1/actions. I did something like this.Password will be asked when you open the appimageupdategui. Please see the image in the link.But in popup /bin/echo will be there instead of appimageupdategui (this is the trickiest part of code). I am trying to fix this as of now. Is it ok to keep /bin/echo? I will update the PR on your further suggestions.

@probonopd
Copy link
Member

Turns out we don't build appimageupdategui yet on Travis CI. I wonder whether we should do a separate GitHub project for it, or build it in the zsync-curl project (another ingredient for the same AppImageUpdate.AppImage).

@abhay44
Copy link
Author

abhay44 commented Feb 27, 2017

So, what's the final verdict?

@probonopd
Copy link
Member

I have some more work to do so that this builds on Travis CI. Still thinking about different options. Probably I will put all things AppImageUpdate into its own repository, so that builds of AppImageKit won't take even longer than they already do.

@abhay44
Copy link
Author

abhay44 commented Mar 3, 2017

@probonopd any update? Travis CI build is passed I think.

@probonopd
Copy link
Member

Travis CI is actually not building this code yet, which is my fault. I still need to set up a proper repository for AppImageUpdate and set up a Travis CI build job for it.

probonopd added a commit to AppImageCommunity/AppImageUpdate that referenced this pull request Mar 8, 2017
@probonopd
Copy link
Member

probonopd commented Mar 8, 2017

Please check AppImageCommunity/AppImageUpdate#1 @abhay44. I opened a new GitHub project especially for AppImageUpdate, which correctly builds the AppImage on each git push.

screenshot from 2017-03-08 18-35-20

TheAssassin added a commit to TheAssassin/AppImageUpdate that referenced this pull request Apr 2, 2017
probonopd pushed a commit to AppImageCommunity/AppImageUpdate that referenced this pull request Apr 2, 2017
* Revert "Try pkexec"

This reverts commit 0073974.

* Revert "Port root authentication from AppImage/AppImageKit#364"

This reverts commit 1ffe5aa.
@probonopd
Copy link
Member

AppImageUpdate has been moved to https://github.com/probonopd/AppImageUpdate.

@probonopd probonopd closed this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants