Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PhotoGIMP #1461

Merged
merged 23 commits into from
Sep 22, 2019
Merged

Create PhotoGIMP #1461

merged 23 commits into from
Sep 22, 2019

Conversation

probonopd
Copy link
Member

@probonopd
Copy link
Member Author

The desktop file has an error:

gimp.desktop: error: value "?????????;?????????;????;??????;????????" for locale string list key "Keywords[mr]" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Please test with a desktop-file-validate version that comes with Ubuntu 16.04 or earlier. Thanks.

@probonopd
Copy link
Member Author

/bin/bash: /run/firejail/appimage/.appimage-8844/AppRun: Permission denied
NUMBER_OF_WINDOWS: 0
ERROR: Could not find a single window on screen :-(

Firejail related?

@sudo-give-me-coffee
Copy link

Apparently yes (netblue30/firejail#2690) the original GIMP does not run either

@probonopd
Copy link
Member Author

probonopd commented Jun 8, 2019

Need to check like this:

sudo apt-get -y install make gcc libz-dev git
git clone https://github.com/plougher/squashfs-tools
cd squashfs-tools/squashfs-tools
make
strip unsquashfs
sudo mv unsquashfs /usr/local/bin

wget -c https://github.com/sudo-give-me-coffee/PhotoGIMP/releases/download/continuous/PhotoGIMP-x86_64.AppImage
chmod +x PhotoGIMP-x86_64.AppImage 
OFFSET=$(./PhotoGIMP-x86_64.AppImage --appimage-offset)
unsquashfs -o $OFFSET ./PhotoGIMP-x86_64.AppImage -ll /
# Need unsquashfs version with -o (e.g., compile from git)

Does it say

drwxrwxr-x root/root              (...) squashfs-root

like the working AppImages? Actually no, it says

drwx------ root/root               (...) squashfs-root

Why? Could it be that the permissions nor non-root users have been missing on the AppDir at AppImage creation time?

@sudo-give-me-coffee
Copy link

Done, now firejail --quiet --noprofile --net = none --appimage ./PhotoGIMP-x86_64.AppImage run perfectly

@probonopd
Copy link
Member Author

/tmp/.mount_BeingTViQ3VV/AppRun: Bourne-Again shell script, ASCII text executable
-rwxrwxr-x 1 root root 2.4K Jun 16 01:24 /tmp/.mount_BeingTViQ3VV/AppRun
kernel.unprivileged_userns_clone = 1
/bin/bash: /run/firejail/appimage/.appimage-8825/AppRun: Permission denied
NUMBER_OF_WINDOWS: 0
ERROR: Could not find a single window on screen :-(

@sudo-give-me-coffee
Copy link

That's can be considered a bug of firejail? all permissions are set to rwxrwxr-x

@sudo-give-me-coffee
Copy link

By runnig with:

xhost +
sudo firejail...

Works but themes, open/save functions not work

@probonopd
Copy link
Member Author

probonopd commented Jun 23, 2019

That's can be considered a bug of firejail? all permissions are set to rwxrwxr-x

No, and no:

me@host:~$ Downloads/PhotoGIMP-x86_64.AppImage /mnt --appimage-offset
188392

me@host:~$ sudo mount -o offset=188392 Downloads/PhotoGIMP-x86_64.AppImage /mnt

me@host:~$ ls -lh /mnt/
ls: cannot open directory '/mnt/': Permission denied

me@host:~$ ls -dlh squashfs-root/
drwx------ 5 me me 200 Jun 23 15:56 squashfs-root/
# This is wrong!

# Fix it
me@host:~$ sudo chmod -R a+rx squashfs-root

me@host:~$ ls -dlh squashfs-root/
drwxr-xr-x 5 me me 200 Jun 23 15:56 squashfs-root/
# This looks good

@probonopd
Copy link
Member Author

probonopd commented Sep 22, 2019

We don't recommend this anymore, users are pointed to appimaged or AppImageLauncher instead.

image

@probonopd probonopd merged commit 45b4f19 into master Sep 22, 2019
@probonopd probonopd deleted the PhotoGIMP branch September 22, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants