Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pelusica #3179

Merged
merged 5 commits into from
Aug 27, 2023
Merged

Create Pelusica #3179

merged 5 commits into from
Aug 27, 2023

Conversation

VitoVan
Copy link
Contributor

@VitoVan VitoVan commented Jun 19, 2023

No description provided.

@VitoVan VitoVan mentioned this pull request Jun 19, 2023
@VitoVan
Copy link
Contributor Author

VitoVan commented Jun 19, 2023

ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5220:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default
debugger invoked on a SDL2-MIXER:SDL-MIXER-ERROR in thread
#<THREAD tid=10 "SDL2 Main Thread" RUNNING {1002A41733}>:
  SDL Error (-1): ALSA: Couldn't open audio device: No such file or directory

This is the same as #3178

I think there might be something need to be done with the audio devices.

Maybe github actions does not support audio devices, so I shouldn't call any audio functions in CI?

@probonopd
Copy link
Member

probonopd commented Jun 19, 2023

Indeed we are running the test on GitHub Actions, probably there is no sound card.

If a sound card is essential to Peluscia, then instead of blindly assuming that every computer has a sound card, it would be good if the application would check this on startup and show an error message dialog if it doesn't find one.

This being said, maybe we could change the test to do something like

# Create a dummy sound card
sudo modprobe snd-dummy || true
cat > /etc/asound.conf <\EOF
pcm.!default {
  type hw
  card Dummy
}
EOF
systemctl restart alsa-utils || true

to simulate a sound card. Whether this is possible on GitHub Actions is questionable, it seems like it is not supported:
pestophagous/heory#4

@probonopd probonopd mentioned this pull request Jun 19, 2023
@VitoVan
Copy link
Contributor Author

VitoVan commented Jun 19, 2023

If a sound card is essential to Peluscia, then instead of blindly assuming that every computer has a sound card, it would be good if the application would check this on startup and show an error message dialog if it doesn't find one.

You are right, I shouldn't open the audio device unconditionally anyway.

Will change this.

@VitoVan
Copy link
Contributor Author

VitoVan commented Jun 25, 2023

This one should be identical with #3178 , but it didn't:

Error: cannot configure loopback device

There is no sign of running Pelusica.AppImage, no log like this.

@probonopd
Copy link
Member

Looks like the test succeeded:

image

@probonopd probonopd merged commit 7e5dea3 into AppImage:master Aug 27, 2023
1 check failed
@VitoVan
Copy link
Contributor Author

VitoVan commented Aug 27, 2023

Thanks!

@VitoVan VitoVan deleted the patch-1 branch August 27, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants