Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sharp-Tune #658

Merged
merged 4 commits into from Jun 28, 2018
Merged

Create Sharp-Tune #658

merged 4 commits into from Jun 28, 2018

Conversation

probonopd
Copy link
Member

No description provided.

@probonopd
Copy link
Member Author

module.js:545
    throw err;
    ^
Error: Cannot find module '/run/firejail/appimage/.appimage-7139/resources/electron.asar/browser/init.js'
    at Function.Module._resolveFilename (module.js:543:15)
    at Function.Module._load (module.js:473:25)
    at Function.Module.runMain (module.js:683:10)
    at startup (bootstrap_node.js:196:16)
    at bootstrap_node.js:622:3
Parent pid 7139, child pid 7142

May be caused by electron-userland/electron-builder#2958

@MD-AZMAL
Copy link

downgraded electron-builder to 20.14.7 ..... this might solve the problem please try again

@probonopd
Copy link
Member Author

@MD-AZMAL
Copy link

MD-AZMAL commented Jun 28, 2018

yes .... when i run it in my environment it just blinks in the tray and closes without any response ... i am on it!

@MD-AZMAL
Copy link

but how did the second test passed if they both had the same issue initially?

@probonopd
Copy link
Member Author

probonopd commented Jun 28, 2018

The second one didn't actually run anything, it can safely be disregarded. I don't know how to prevent Travis CI from running it.

@MD-AZMAL
Copy link

oh i see .... still trying to fix it the solution provided did'nt work so need to find something else

@MD-AZMAL
Copy link

Good news! fixed the issue now it runs perfectly on my system ..... i have updated the files in the release too.... please see if it works

@probonopd probonopd merged commit 2be06dc into master Jun 28, 2018
@probonopd probonopd deleted the Sharp-Tune branch June 28, 2018 21:00
@probonopd
Copy link
Member Author

probonopd commented Jun 28, 2018

Congratulations for being the 400th app to be listed on https://appimage.github.io/apps/ 👍

@MD-AZMAL
Copy link

i am so glad 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants