Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsyncmake2 output path support #73

Open
lalten opened this issue Apr 8, 2024 · 4 comments
Open

zsyncmake2 output path support #73

lalten opened this issue Apr 8, 2024 · 4 comments

Comments

@lalten
Copy link

lalten commented Apr 8, 2024

Original zsyncmake supports -o outputfile which is very handy for scripting: https://linux.die.net/man/1/zsyncmake#:~:text=finished%20downloading%20it).-,%2Do%20outputfile,-Override%20the%20default

https://github.com/th-in-gs/zsync/blob/d1558117e264df7f779e99624fc8a6732b571c9f/make.c#L549-L555

Would be great for zsyncmake2 to support this feature as well.

@probonopd
Copy link
Member

What would be a use case for wanting a different file name than the default one?

@lalten
Copy link
Author

lalten commented Apr 8, 2024

In my case I'm calling zsyncmake2 from a Bazel run target. Path setups are kind of important in the Bazel world. Currently, every invocation of running zsyncmake2 will clutter up the runfiles dir of all future invocations. For reasons I won't go into detail here about the directory where you launch the program will not and can not be the working directory during execution.

@probonopd
Copy link
Member

I see. Would the ability to just specify a different path (but not filename) be sufficient for your use case?

@lalten
Copy link
Author

lalten commented Apr 9, 2024

That would be not ideal (because I still need to write logic around the call to calculate what the output filename will be so it can be used elsewhere afterwards) -- but better than the status quo (where I have to hardcode implementation details for path assumptions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants