-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask For Permission attached to specific slide #1149
Comments
Can you clarify what is a TAG in this context? |
I got it from your PR, thanks for submitting it. I think this change is quite invasive and I'm unsure we want to offer it. |
Invasive? Its a relatively small change, that doesnt even affect existing installations, what problems do you see for the future with this? Is there something i could improve? |
You're basically introducing a new concept (the 'tag') for all the users, that is needed only for a specific feature. I'd rather find a different approach. For example, something like this overload:
would work better imho |
The tag itself is entirely optional, but i see the point that it might make the change bigger than it needs to be. Though implementing your Fragment argument might require a huge change to the code to fit it into the permissionMap without breaking the existing slideNumbers. However, another addition to attaching permissions to a specific slide would be, that it makes recognizing a specific slide more easy. As an eyample, to request storage permissions i have to write custom code and call that. To do so, i need to check on which slide i am, and on what slide i am supposed to make the request. I have to keep track of the slideNumbers again. With a tag, i can just check wether or not i am on my target slide. On the other hand, i will have to check if it is possible to archieve the same with a reference to the fragment itself as you proposed. |
I have updated the PR to accept a fragment:
The tag is now an id, and a property of AppIntroFragment (AppIntroFragment.slideId) |
When dealing with different API-Levels, it might not be nessessary to ask for specific permissions. In those cases, the slide numbers change for permissions on the next slide. This means the developer needs to keep track of the slide position himself.
💡 Describe the solution you'd like
I would like to see a method that lets the developer to attach a permission to a specifc slide via tags.
If a slide is shown with TAG, then the permission can be requested either on or after the slide is shown.
🤚 Do you want to develop this feature yourself?
The text was updated successfully, but these errors were encountered: