Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register callback on onBackPressedDispatcher #1051

Merged
merged 2 commits into from Oct 2, 2022
Merged

Register callback on onBackPressedDispatcher #1051

merged 2 commits into from Oct 2, 2022

Conversation

rubenquadros
Copy link
Contributor

@rubenquadros rubenquadros commented Oct 2, 2022 •
edited by cortinico

This PR is for the issue: #1049

Removed onBackPressed and handled it via registering OnBackPressedCallback on onBackPressedDispatcher

Fixes #1049

cortinico
cortinico approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me 👍 I'll do some test and we can merge it

@cortinico
Copy link
Member

You need to fix the linter:

/home/runner/work/AppIntro/AppIntro/appintro/src/main/java/com/github/appintro/AppIntroBase.kt:548:45 Missing newline after "(" (indent)
/home/runner/work/AppIntro/AppIntro/appintro/src/main/java/com/github/appintro/AppIntroBase.kt:548:50 Missing newline after "," (indent)
/home/runner/work/AppIntro/AppIntro/appintro/src/main/java/com/github/appintro/AppIntroBase.kt:560:9 Missing newline before ")" (indent)

@cortinico
Copy link
Member

I've tested it and it's fine 👍 Let's merge this once the linter is green

@rubenquadros
Copy link
Contributor Author

Fixed the lint errors

@cortinico cortinico enabled auto-merge (squash) October 2, 2022 11:41
@cortinico cortinico merged commit 9c78905 into AppIntro:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle onBackPressed deprecation
2 participants
@rubenquadros @cortinico