Best2Pay: fixed a crash when order doesn't have e-mail or phone data

AppRopio · Jun 4, 2019 · 20b6ddb · 20b6ddb
1 parent cd81a5c
commit 20b6ddb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/app-ropio/AppRopio.Payments/Best2Pay/API/Request/B2PEpaymentRequest.cs b/src/app-ropio/AppRopio.Payments/Best2Pay/API/Request/B2PEpaymentRequest.cs
@@ -23,7 +23,7 @@ public string RequestString(int sector, string password, string forwardURL)
             if (ID != -1) data += "&id=" + ID;
             if (!string.IsNullOrEmpty(firstname) && firstname.Length != 0) data += "&firstname=" + firstname;
             if (!string.IsNullOrEmpty(lastname) && lastname.Length != 0) data += "&lastname=" + lastname;
-            if (email.Length != 0) data += "&email=" + email;
+            if (!string.IsNullOrEmpty(email) && email.Length != 0) data += "&email=" + email;
             data += "&wm=" + (wm ? "1" : "0");
             data += "&ym=" + (ym ? "1" : "0");
             data += "&qiwi=" + (qiwi ? "1" : "0");
@@ -48,7 +48,7 @@ public string RequestString(int sector, string password, string forwardURL)
 
             if (!string.IsNullOrEmpty(lastname) && lastname.Length != 0) data.Add("lastname", lastname);
 
-            if (email.Length != 0) data.Add("email", email);
+            if (!string.IsNullOrEmpty(email) && email.Length != 0) data.Add("email", email);
 
             data.Add("wm", (wm ? "1" : "0"));
 

diff --git a/src/app-ropio/AppRopio.Payments/Best2Pay/API/Request/B2PRegisterRequest.cs b/src/app-ropio/AppRopio.Payments/Best2Pay/API/Request/B2PRegisterRequest.cs
@@ -34,8 +34,8 @@ public string RequestString(int sector, string password, string forwardURL)
             if (description.Length != 0) data += "&description=" + description;
             data += "&sector=" + sector;
             data += "&url=" + forwardURL;
-            if (email.Length != 0) data += "&email=" + email;
-            if (phone.Length != 0) data += "&phone=" + phone;
+            if (!string.IsNullOrEmpty(email) && email.Length != 0) data += "&email=" + email;
+            if (!string.IsNullOrEmpty(phone) && phone.Length != 0) data += "&phone=" + phone;
             if (signature.Length != 0) data += "&signature=" + signature;
             if (bank_name.Length != 0) data += "&bank_name=" + bank_name;
             if (address.Length != 0) data += "&address=" + address;
@@ -71,9 +71,9 @@ public string RequestString(int sector, string password, string forwardURL)
             data.Add("sector", sector.ToString());
             data.Add("url", forwardURL);
 
-            if (email.Length != 0) data.Add("email", email);
+            if (!string.IsNullOrEmpty(email) && email.Length != 0) data.Add("email", email);
 
-            if (phone.Length != 0) data.Add("phone", phone);
+            if (!string.IsNullOrEmpty(phone) && phone.Length != 0) data.Add("phone", phone);
 
             if (signature.Length != 0) data.Add("signature", signature);