-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search2 integrated #3011
Closed
Closed
Search2 integrated #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts helps to: - install SolrCloud; - configure it to use Zookeeper of deployment; - create "appscale-search-api-config" config set in Solr; - enable and start Solr service.
- antlr4 grammar was added; - appscale syntax tree preprocessor was added; - build script for compiling antlr4 parser was added.
- Number of models corresponds to GAE Search API objects; - Others helper models represent Solr objects.
- solr_api takes care of communication with SolrCloud; - constants were also added.
- Solr Adapter implements functionality of Search API using Solr. - query_convertor could be a part of solr_adapter but this chunk of functionality worth own module.
- api_methods takes care of protobuf serialization-deserialization; - *.proto files contains protocol definitions.
- search_server is main module of SearchService2; - ensure_searchservice2.sh takes care of compilation of protocols and grammar and installs search package.
Also added support for multiple search_ip addresses.
- use /etc/appscale/search2_ips for storing Search2 locations; - fail during runtime if Solr 7.6 is not installed; - raise client error if feature is not supported; - use nargs='+' for zk-locations argument;
These were introduced in the 1.9.0 SDK.
These were introduced in the 1.9.1 SDK.
This was introduced in the 1.9.8 SDK.
This change was introduced in the 1.9.11 SDK.
These changes were introduced in the 1.9.14 SDK.
- Add facet-related models; - Add conversion of facet-related models to and from protobuf.
- Add handling of facet arguments in solr_adapter; - Add stats argument to solr_api; - Update solr fields mapping; - Add grouped index and value facets; - Add facet_converter which handled adoption of Solr API to Search API; - Minor update in schema.
- Added auto registration of server in Zookeeper. - Added health probe handler. - Managing search settings.
- Make it easier to add new services to service manager. - Add search service to service manager.
- Implement search assignment management to AC. - Add heap-reduction parameter when starting Solr.
- Resolve sort expression serialization. - ignore deadline argument.
- Expect other node to create zookeeper root. - Delete incompletely created collections. - Warn if there is incompletely created collection.
* search2-facets: Fix SDK search part Implement simple NumberFacet search Add unit tests for SearchService2 Implement Facetted search in solr_adapter Add facet-related models Add faceted search support to the Python runtime Remove references to undefined ContentType class Add FacetRefinement field to FacetResultValue Include more facet-related protobuffer definitions Include facet-related protocol buffer definitions
This was referenced Mar 7, 2019
jeanleonov
force-pushed
the
search2-integrated
branch
4 times, most recently
from
March 21, 2019 15:53
5bffaba
to
87242ac
Compare
jeanleonov
force-pushed
the
search2-integrated
branch
from
March 21, 2019 19:07
87242ac
to
1f1f731
Compare
Download antlr from s3 bucket.
jeanleonov
force-pushed
the
search2-integrated
branch
from
March 22, 2019 15:41
1f1f731
to
9bd7b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could already hear something about SearchService2.
Related PRs will be referred later (new role in appscale-tools, hawkeye tests and another AppScalefile template to be tested with hawkeye).
Depends on:
Regression tests:
https://ocd.appscale.com:8080/job/Daily%20Build/5991/