Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to override capabilites from environment variables #473

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Conversation

anandbagmar
Copy link
Member

added ability to override capabilites from environment variables

@saikrishna321
Copy link
Member

@anandbagmar How would you pass the app capability for both iOS real device and iOS Simulator?

@anandbagmar
Copy link
Member Author

@saikrishna321 - if we want Platform specific updates, I can update the PR based on that.
Ex: to override any capability, set the env var as:
android.app=.... - which will update / add to the android config only. ]

Would that approach be better?

@saikrishna321
Copy link
Member

@anandbagmar We need to change approach after this PR got merged #478

Now we will default to "app": {
"local": ".../../something.apk",
"cloud": "CloudURL to apk"
}

@anandbagmar
Copy link
Member Author

Cool. Will take a look and update the PR

@sumitbera
Copy link
Contributor

@anandbagmar This will be very helpful. I'm also stuck at this point. I have to use APK path from Bitrise CI. Would be really nice if you finish this

anandbagmar and others added 2 commits June 10, 2019 15:52
…ome property, we need to pass this as an environment variable in a specific format:

ex: to update android's app path, set env var as: 'atd.android.app'
ex: To update a specific property as part of an array, 'atd.hostMachines.0.appiumServerPath=.... '
ex: To update the 1st simulator's device name in the 1st hostMachine: 'atd.hostMachines.0.simulators.0.deviceName
@anandbagmar
Copy link
Member Author

anandbagmar commented Jun 10, 2019

@saikrishna321 , @SrinivasanTarget - I have updated this PR. Here are some examples how to update the capabilities using environment variables:

  • to update android's app path, set env var as:
    atd_android_app=<new path>
  • To update a specific property as part of an array,
    atd_hostMachines_0_appiumServerPath=<new path>
  • To update the 1st simulator's device name in the 1st hostMachine: atd_hostMachines_0_simulators_0_deviceName=<new name>

Let me know if this seems ok

@saikrishna321 saikrishna321 merged commit 77af563 into AppiumTestDistribution:master Jun 12, 2019
@anandbagmar
Copy link
Member Author

@saikrishna321 , @SrinivasanTarget - thanks for merging the PR. Any idea when will this be available via maven, and with what version #?

@saikrishna321
Copy link
Member

The next version will be major release v12.0.0 - cloud support and contract change on app capability.

Once the docs are done we can release

@anandbagmar
Copy link
Member Author

ok. Hopefully that happens soon :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants