Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle adb timeout #899

Merged

Conversation

afathonih
Copy link
Contributor

In my device-farm, the hub/nodes sometimes crash with the following log:

[ADB] Running '/Users/ci/Library/Android SDK/platform-tools/adb -P 5037 -s abcdef shell getprop init.svc.bootanim'
uncaughtException: Timed out after waiting for 60000 ms
Error: Timed out after waiting for 60000 ms
    at /Users/ci/.appium/node_modules/appium-device-farm/node_modules/async-wait-until/dist/index.js:1:1034
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)
uncaughtException: Timed out after waiting for 60000 ms

This PR adds typing for getDeviceProperty and adds graceful handling for other methods when getDeviceProperty returns undefined.

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appium-device-farm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 1:56am

@saikrishna321 saikrishna321 merged commit 4905c66 into AppiumTestDistribution:main Nov 20, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants