Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested interval when updating devices from node. #902

Merged

Conversation

afathonih
Copy link
Contributor

@afathonih afathonih commented Nov 22, 2023

Changes:

  • Remove nested setInterval. My previous PR has nested setInterval calls to update node devices.
  • Aligning the values (5 minutes) for interval check on: node-availabilities (remove stale devices), update-device (sending node devices to hub), and release-blocked-devices.
  • Ignore session filter and use udid instead when checking/releasing blocked devices. It will solely depends onlastCmdExecutedAt.
  • Catch error when sending device updates to hub. The callers have never aware of the potential failure.
  • Add test for releasing blocked device based onlastCmdExecutedAt
  • Renames some methods to reduce ambiguity. E.g.: checkNodeServerAvailability to setupCronCheckNodesAvailability

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appium-device-farm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 0:31am

src/device-utils.ts Outdated Show resolved Hide resolved
chore: update deps to make eslint works
@saikrishna321
Copy link
Member

@afathonih You also need to add the schema contract in package.json - https://github.com/AppiumTestDistribution/appium-device-farm/blob/main/package.json#L155-L200

Also please update the docs - https://github.com/AppiumTestDistribution/appium-device-farm/blob/main/docs/server-args.md

Update the sample-config - https://github.com/AppiumTestDistribution/appium-device-farm/blob/main/sample-config.json

test/e2e/hubnode.spec.ts Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@saikrishna321
Copy link
Member

@afathonih Browerstack running in linux is for iOS test - App URL - bs://6585528cee5f3b2700b54250c12d81bd7f235a3c

@afathonih
Copy link
Contributor Author

afathonih commented Dec 6, 2023

bug: device-farm endpoint is 404 Solved. Test added.

@saikrishna321
Copy link
Member

@afathonih Thanks for fixing the CI. Can you please bump minor version and update the package.json and lock.json

@saikrishna321 saikrishna321 merged commit 183871d into AppiumTestDistribution:main Dec 7, 2023
14 of 16 checks passed
Copy link

github-actions bot commented Dec 7, 2023

🚀 [bumpr] Bumped! New version:v8.3.0 Changes:v8.2.19...v8.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants