Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify refresh behaviour for Schedule View #292

Merged
merged 3 commits into from
Nov 13, 2021

Conversation

JonathanDuvalV
Copy link
Contributor

This removes the refresh button in the schedule view and replaces it with the drag down to refresh just like the grade/grade_detail views. This is needed in #211

@JonathanDuvalV JonathanDuvalV requested a review from a team November 13, 2021 05:40
@JonathanDuvalV JonathanDuvalV self-assigned this Nov 13, 2021
@JonathanDuvalV
Copy link
Contributor Author

Closes #201

@JonathanDuvalV JonathanDuvalV linked an issue Nov 13, 2021 that may be closed by this pull request
Copy link
Member

@apomalyn apomalyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the build and LGTM!!

Copy link
Contributor

@MysticFragilist MysticFragilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonathanDuvalV JonathanDuvalV merged commit ff3e3ef into master Nov 13, 2021
@JonathanDuvalV JonathanDuvalV deleted the feature/refresh-schedule branch November 13, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the refresh behaviour
3 participants