Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello/master #981

Merged
merged 233 commits into from
Jun 3, 2024
Merged

Hello/master #981

merged 233 commits into from
Jun 3, 2024

Conversation

XavierPaquet-Rapold
Copy link
Contributor

πŸ“– Description

Hello project

πŸ§ͺ How Has This Been Tested?

Just to check the changes

β˜‘οΈ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

πŸ–ΌοΈ Screenshots (if useful):

@XavierPaquet-Rapold XavierPaquet-Rapold marked this pull request as ready for review June 1, 2024 16:03
Copy link
Contributor

@MysticFragilist MysticFragilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je laisse ça pour l'instant je continue de regarder ça en après-midi!

.github/workflows/release-workflow.yaml Outdated Show resolved Hide resolved
l10n/intl_en.arb Outdated Show resolved Hide resolved
l10n/intl_en.arb Show resolved Hide resolved
l10n/intl_en.arb Outdated Show resolved Hide resolved
l10n/intl_en.arb Show resolved Hide resolved
l10n/intl_fr.arb Outdated Show resolved Hide resolved
XavierPaquet-Rapold and others added 4 commits June 1, 2024 12:20
Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>
Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>
Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>
MysticFragilist
MysticFragilist previously approved these changes Jun 1, 2024
Copy link
Contributor

@MysticFragilist MysticFragilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le reste semble good! LGTM! πŸ’―

Copy link

github-actions bot commented Jun 3, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jun 3, 2024

Coverage after merging hello/master into master will be

73.52%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
Β  Β locator.dart3.85%100%100%3.85%30, 32–44, 47–53, 56–59
lib/core/constants
Β  Β preferences_flags.dart0%100%100%0%61, 66, 68, 70–72, 75, 77–80, 82, 84
Β  Β widget_helper.dart100%100%100%100%
Β  Β quick_links.dart100%100%100%100%
Β  Β emergency_procedures.dart100%100%100%100%
Β  Β markers.dart100%100%100%100%
Β  Β report_news.dart0%100%100%0%11, 13–15, 17–18, 20, 22–24, 6–9
lib/core/extensions
Β  Β webview_controller_extension.dart88.89%100%100%88.89%21
lib/core/managers
Β  Β author_repository.dart0%100%100%0%17, 19
Β  Β cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
Β  Β course_repository.dart84.68%100%100%84.68%193, 198, 204, 206, 210, 212–213, 216–222, 227, 229, 232, 234–236, 239–244, 248, 252–254, 256, 260, 330, 338, 340, 525–526, 76
Β  Β news_repository.dart0%100%100%0%20, 25
Β  Β quick_link_repository.dart85.71%100%100%85.71%39–40
Β  Β settings_manager.dart89.15%100%100%89.15%221, 227, 230, 234, 236, 256, 258–259, 272, 274–276, 39, 88
Β  Β user_repository.dart93.52%100%100%93.52%131–132, 182, 304, 306, 94–95
lib/core/models
Β  Β quick_link.dart100%100%100%100%
Β  Β quick_link_data.dart100%100%100%100%
Β  Β widget_models.dart100%100%100%100%
Β  Β feedback_issue.dart100%100%100%100%
Β  Β discovery.dart100%100%100%100%
Β  Β group_discovery.dart100%100%100%100%
Β  Β emergency_procedure.dart100%100%100%100%
Β  Β report_news.dart100%100%100%100%
Β  Β social_link.dart100%100%100%100%
Β  Β faq_actions.dart100%100%100%100%
Β  Β faq_questions.dart100%100%100%100%
lib/core/services
Β  Β preferences_service.dart69.09%100%100%69.09%119–120, 122, 36, 38, 40, 43–45, 69–70, 80–82, 85, 87–88
Β  Β analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
Β  Β app_widget_service.dart77.42%100%100%77.42%71, 73–78
Β  Β github_api.dart0%100%100%0%100–101, 104, 106, 110, 112–116, 118–119, 122, 124, 131–134, 138–139, 141, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 70, 77, 82–88, 92, 94, 96–98
Β  Β in_app_review_service.dart0%100%100%0%16, 20, 23, 27
Β  Β internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
Β  Β launch_url_service.dart0%100%100%0%16–18, 21–23, 26–31, 37, 55–56, 59
Β  Β navigation_service.dart0%100%100%0%27, 30–31, 33–34, 41–42, 45–46, 49–51, 53, 58, 61, 63–64, 67–69, 71–72
Β  Β networking_service.dart0%100%100%0%10–11, 13–15, 18–20
Β  Β remote_config_service.dart0%100%100%0%100, 103–105, 108–110, 113–115, 118–120, 123–125, 128–130, 133–135, 138–140, 143–144, 146–150, 154–156, 58–60, 63–65, 68–70, 73–75, 78–80, 83–85, 88–90, 93–95, 98–99
Β  Β rive_animation_service.dart0%100%100%0%12–13, 16, 19–20, 28, 32–33, 35
Β  Β siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/core/utils
Β  Β cache_exception.dart100%100%100%100%
Β  Β animation_exception.dart20%100%100%20%15, 17–19
Β  Β utils.dart63.33%100%100%63.33%12–15, 17–18, 44–45, 48–49, 64
Β  Β login_mask.dart5%100%100%5%12, 15–16, 18–20, 23–30, 33–34, 37–39
Β  Β calendar_utils.dart0%100%100%0%100, 104, 106–109, 11, 110, 112–113, 115, 118–121, 127–128, 13, 131, 134, 138, 14, 145, 150, 153, 155, 160, 164–165, 169, 17, 170–171, 173–175, 179, 183, 19, 21, 35–36, 38, 40–41, 45–48, 56, 59–60, 63, 68, 7, 71, 77, 79–80, 83, 87–88, 9, 92–94
lib/core/viewmodels
Β  Β news_viewmodel.dart71.43%100%100%71.43%42, 46–48
Β  Β quick_links_viewmodel.dart100%100%100%100%
Β  Β web_link_card_viewmodel.dart62.50%100%100%62.50%35, 40–41
Β  Β login_viewmodel.dart100%100%100%100%
Β  Β security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
Β  Β grades_details_viewmodel.dart96.67%100%100%96.67%53
Β  Β schedule_settings_viewmodel.dart77.38%100%100%77.38%118–122, 138, 140, 142, 145, 148–149, 151, 65, 67–72
Β  Β schedule_viewmodel.dart79.47%100%100%79.47%100, 102–106, 108, 123, 147, 164, 166–167, 169, 171–176, 215, 227, 283–284, 320, 370–374, 382–383, 406–409, 412–413, 446–447
Β  Β choose_language_viewmodel.dart100%100%100%100%
Β  Β grades_viewmodel.dart100%100%100%100%
Β  Β profile_viewmodel.dart96%100%100%96%126–127
Β  Β feedback_viewmodel.dart97.14%100%100%97.14%63
Β  Β not_found_viewmodel.dart100%100%100%100%
Β  Β schedule_default_viewmodel.dart92.50%100%100%92.50%59, 98–99
Β  Β settings_viewmodel.dart100%100%100%100%
Β  Β calendar_selection_viewmodel.dart0%100%100%0%20, 25–26, 29–35, 38, 41–43, 46, 48–49, 51, 55–56, 58, 60, 65–68, 70, 72, 77–78
Β  Β news_details_viewmodel.dart100%100%100%100%
Β  Β report_news_viewmodel.dart0%100%100%0%10–12
Β  Β author_viewmodel.dart68%100%100%68%56, 60, 62–65, 68–69
Β  Β more_viewmodel.dart64.71%100%100%64.71%110, 112–114, 116–117, 119, 124–125, 144–145, 147–148, 150–151, 154–155, 64
Β  Β faq_viewmodel.dart41.67%100%100%41.67%30, 32–33, 35, 38, 41, 43

@XavierPaquet-Rapold XavierPaquet-Rapold merged commit 716f90c into master Jun 3, 2024
7 checks passed
@XavierPaquet-Rapold XavierPaquet-Rapold deleted the hello/master branch June 3, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants