Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on compiling? #30

Closed
philgoetz opened this issue Dec 11, 2018 · 7 comments
Closed

Documentation on compiling? #30

philgoetz opened this issue Dec 11, 2018 · 7 comments

Comments

@philgoetz
Copy link

Can you create some documentation on how to compile this? It appears to use gradle, which I've never used. What do I need to type at the command line to compile it?

@a2geek
Copy link
Contributor

a2geek commented Mar 3, 2019

There is a start here: https://github.com/AppleCommander/AppleCommander/blob/master/DEVELOPER.md

However, I do tend to keep things light. Let me know if there is anything else needed.

I tend to develop on a Linux desktop, so if you're on other platforms, there may be adjustments/enhancements to make.

@philgoetz
Copy link
Author

philgoetz commented May 1, 2019

It appears that newer versions of Java require newer versions of Gradle.

$ ./gradlew test

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '11.0.1'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

This post says: Gradle has fixed the issue in Gradle 4.7 .

But you appear to be using a version of gradle installed in your AppleCommander distro, so my upgrading gradle won't immediately fix that, I think?

a2geek added a commit that referenced this issue Sep 29, 2019
@a2geek
Copy link
Contributor

a2geek commented Sep 29, 2019

Just bumped the version of Gradle to the latest:

$ ./gradlew --version

------------------------------------------------------------
Gradle 5.6.2
------------------------------------------------------------

Build time:   2019-09-05 16:13:54 UTC
Revision:     55a5e53d855db8fc7b0e494412fc624051a8e781

Kotlin:       1.3.41
Groovy:       2.5.4
Ant:          Apache Ant(TM) version 1.9.14 compiled on March 12 2019
JVM:          11.0.4 (Ubuntu 11.0.4+11-post-Ubuntu-1ubuntu218.04.3)
OS:           Linux 4.15.0-64-generic amd64

@a2geek a2geek added this to In progress in AppleCommander 1.6.0 Sep 29, 2019
@philgoetz
Copy link
Author

It works now!
I suggest adding a note to DEVELOPER.md saying that the built .jar files are in /build/libs, and also that you should use the win64 version if you have Windows 64-bit, and also that the .jar filename will be set to the name of the current working directory.

Thanks!

AppleCommander 1.6.0 automation moved this from In progress to Done Sep 30, 2019
a2geek added a commit that referenced this issue Oct 1, 2019
@philgoetz philgoetz reopened this Feb 5, 2020
@philgoetz
Copy link
Author

I tried to compile the new version, to see if the Windows bug has been fixed, and I can't figure out how to compile it.
I didn't keep notes on how I did it last time, but it seems to use a different process, since ./gradlew test doesn't do anything except print informational messages, and there is no build/libs directory.
Please put some instructions somewhere on how to compile AppleCommander.

@a2geek
Copy link
Contributor

a2geek commented Feb 8, 2020

The updates for #35 are included in AppleCommander 1.6.0, and you can download it here: https://github.com/AppleCommander/AppleCommander/releases/tag/v1-6-0

As far as compiling, it's the Gradle ecosystem. Notes here: https://github.com/AppleCommander/AppleCommander/blob/master/DEVELOPER.md

Gradle is here: https://gradle.org/. This is a big topic and I don't think AC should be documenting how to use or setup Gradle. If details are missing, then certainly, that should be remediated.

@a2geek a2geek added this to To Do in AppleCommander 1.7.0 Nov 17, 2020
@a2geek a2geek removed this from To Do in AppleCommander 1.7.0 Jan 13, 2022
@a2geek
Copy link
Contributor

a2geek commented Mar 10, 2022

Closing due to inactivity.

@a2geek a2geek closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants