debugger: search range off by one?

[peterferrie]

example, s 0:1fff dd
will search only 0..1ffe. I expected it to look at 1fff, too.
If it's intentional, then I'll have to be more careful.

[tomcw]

The notation you are using is s <address-start>:<length> <hex>, so for the specific example you gave, with a length of 1fff it will only search [0...1ffe].

There is alternate notation (using comma instead of colon) which is: s <address-start>,<address-end> <hex>, which should search [0...1fff].

EDIT: the above notation is wrong (I got it backwards)... see below!

But when I tried this there is an off-by-one bug.
So let me get this fixed, and then supply you with an update.

[peterferrie]

The notation you are using is `s <address-start>:<length> <hex>`, so for the specific example you gave, with a length of 1fff it will only search [0...1ffe].

':' appears to be interpreted as an end address, unless there's a parsing issue. 4000:A9 41 85 01 S 4000:4003 1 returns no found, but. S 4000:4004 1 returns 4003. So, I should stop using ':' as the end address?

There is alternate notation (using comma instead of colon) which is: `s <address-start>,<address-end> <hex>`, which should search [0...1fff].

Okay, I will switch to that.

But when I tried this _there is_ an off-by-one bug. So let me get this fixed, and then supply you with an update.

Thanks.

[tomcw]

':' appears to be interpreted as an end address

Yes, you're right (I got it backwards)...

Regardless, there's still an off-by-one bug.

[tomcw]

Repro:

4000:A9 41 85 01
40FE:A9 41 85 01

; Quick tests for "found" case
s 4000:4003 1
s 4000,4 1
s 40FE:4101 1
s 40FE,4 1

s 4000,4 A9 41
s 4000,4 41 85
s 4000,4 85 1
s 40FE,4 A9 41
s 40FE,4 41 85
s 40FE,4 85 1

s 4000,4 A9 41 85
s 4000,4 41 85 1
s 40FE,4 A9 41 85
s 40FE,4 41 85 1

s 4000,4 A9 41 85 1
s 40FE,4 A9 41 85 1

; Quick tests for "not found" case
s 4000:4002 1
s 4000,3 1
s 40FE:4100 1
s 40FE,3 1

; Other tests:
s d000:ffff "FLAS"
s d000,3fff "FLAS"

s ffff:ffff c3
s ffff,1 c3

NB. address , length is correctly bounds checked, and gets capped to 0xFFFF if it exceeds 64KiB.

[tomcw]

@peterferrie - here's a point-release which fixes #1126 and this one:
AppleWin-1.30.11.1.zip

Can you give it a go, and confirm that it fixes things for you? (I'll do a proper release soon)

[peterferrie]

Yes, working for me. Thanks!

[tomcw]

Closing as confirmed as fixed.

[tomcw]

Officially fixed in this new AppleWin 1.30.12.0.

[Michaelangel007]

@tomcw Thanks for fixing this off-by-one bug.

@peterferrie I've been using the : notation for decades. It should be inclusive as documented with the examples.