Fix issue where this package was interfering with SwiftUI previews #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ApplebaumIan any chance we can integrate this? Seems to be a bigger issue with Xcode 15 beta. |
|
After testing the package it does seem to resolve the SwiftUI Preview issue! I also like the new close button, but I may add an option to change the button to a check mark for those types of use cases! Thank you! @andylin2004 |
|
The new close button is more meant for watchOS 10, which places less emphasis on text buttons in the toolbar and more on image based buttons. On Jul 28, 2023, at 2:01 PM, Ian Tyler Applebaum ***@***.***> wrote:
Merged #7 into main.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous release, the #error statement kept on tripping the SwiftUI previews for other OSes into thinking that it needs to compile the digit pad in this package. This PR should try to mitigate this issue by using the @available(platform, unavailable) pattern on the top of a struct, as well as adding the other OSes onto the Package.swift (as seen in #5). I think this is technically an Xcode issue, but that bug has been here for a while to the point that this might be the best we can do at the moment.