Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for real player in crafting listeners #2561

Closed
RealGrep opened this issue Nov 3, 2016 · 3 comments
Closed

Add check for real player in crafting listeners #2561

RealGrep opened this issue Nov 3, 2016 · 3 comments

Comments

@RealGrep
Copy link

RealGrep commented Nov 3, 2016

Description

The new version of reliquary is causing all patterns created to be invalid. I filed a PR there, and he said it's because AE2 needs to add a check for a player here, since it's assuming all crafting listeners are players:

https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/master/src/main/java/appeng/container/implementations/ContainerPatternTerm.java#L498

The PR in question: P3pp3rF1y/Reliquary#186

Environment

  • Minecraft Version: 1.10.2
  • AE2 Version: rv4-alpha-3
  • Forge Version: 2116
  • Reliquary Version: 1.10.2-1.3.3.585
  • SMP
@ozhound
Copy link

ozhound commented Nov 3, 2016

I am seeing the same problem. I can not confirm that it is Reliquary though.

@ozhound
Copy link

ozhound commented Nov 3, 2016

Also Chisel and Bits is having an issue with the same Tear error bug
https://paste.ubuntu.com/23419764/

@predakanga
Copy link

Can confirm that guarding the referenced line with an IContainerListener instanceof EntityPlayerMP check enables patterns to work with the latest versions of Reliquary.

I'm not certain of any further ramifications though, so I won't provide a PR.

@yueh yueh closed this as completed in 6f15c29 Nov 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants