New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bug that can be used to duplicate any items! #2655
Comments
and which AE2 Version did you use ? which minecraft version is that? i mean nice video but how should we guess what you are on :) |
appliedenergistics2-rv3-beta-6 |
forge:1.7.10-10.13.4.1614-1.7.10 |
oookay, i am gonna try this on evening XD |
now I have to ban the ME Controller |
do you have channels disabled on your video ? |
what does "channels disabled on your video" mean? |
I test with only AE2mod,the bug is still exist. |
I have other ideas but ban the controller |
Over the past few months, some players duplicated a lot of items. |
i will test this in a few hours if not somebody else is faster, stay a bit patient, i am sure it is only a special case and if not it will work with similar setups without controller also in the meantime just some more infos for me please, is this video demo in multiplayer or single player? if multiplayer, are there any things like sponge, bukkit, cauldron present? |
multiplayer server: Thermos-1.7.10-1614-58-server |
yeah i can confirm this @yueh and i also have a strong guess
|
Even if it should happen, as long as it does not affect rv4 we will not fix it. |
dupe works fine on 1.10.2 rv4 a6 |
I think I have fixed it, will do a PR in a few minutes to test (for rv4) |
@mindforger Could you please fetch the build for #2657 from jenkins and verify it? |
in about 10hours or so i can test :) |
is there a slight chance this will turn into an rv3 a7 eventually ? :) if by chance this video/info spreads it will ruin a lot of 1.7.10 servers i guess |
I have deleted this video. :) |
removed my explanation for the sake of running servers :) |
It is actually a duplicate of #2276, so there are already enough documented ways to reproduce it. And no we will not release a new rv3 build. Potentially a stable to preserve the last version as moving rv4 to beta will overwrite them. |
that one O_o i thought this one was solved already ... well okay then :) EDIT: ahhhh it was that one that escalated so bad because of somebody thinking you get payed from mojang because he payed mojang for the game EDIT2: @yueh quote of yourself
dunno if that is related to your change but it almost looks like |
I saw #2276 ,then I found that two separate ME systems can be confusing. |
not if it is related, it's most likely the same bug and the fix would help against both probably if you are able, insall youself an 1.10 version and try the jenkins build that yueh asked me to test, i still have at least 3 hours of work to do before i can do it :) |
After my test,it do not fix both. |
//fix I build GridStorageCache.class myself. |
ah okay sorry i misunderstood your post the first time, you already tested it, thank you :) |
https://youtu.be/aqFz9YLdHgA |
so it seems like the cache is not updated properly while somebody is looking at the interface |
I am waiting for the fixing code |
i would almost bet that
is firing and goes unnoticed @azbh11 you can try to patch this with a log output of the actual fired exception trace and see if my guess was right XD EDIT: whoops wrong line EDIT2: try-catch without even a configurable log output is kindof bad programming practice in my opinion when the thrown exception is not 100% by design |
Has
|
i changed the line in my comment, i was mistaken for the call, it is line 126 not 152 and no it is not fixed but i pointed out that this empty catch may be dropping an unhandled exception, you can try to insert a log output there and see if it fires when you do that exploit @yueh i top my guess with an additional bet, when it fires i bet it is an concurrent modification exception |
there is no exception be thrown. |
darn it, okay i was looking for the connection between an open terminal view and the broken cable but i only know about the remove() call for a node and this was the only connection between them |
It is funny how this takes the exact same route as the last one..
Nevertheless, should be fixed now once the new build for the PR is done. |
whoops forgot to write last evening how to reproduce: build a similar setup like before, open the terminal and sorry for the wild guessing there but after i got behind the update route i was so sure that the update throws an exception which is silently discarded and the update aborted, resulting in a missing terminal update PS i did not test yet the changes you did 24minutes before to the fix |
@yeah did you want me to test this and the other linked bug on the latest build for you? If so, I'll need steps to reproduce this bug, but the other one I still actually have that save. Lol. |
@bookerthegeek make a simple setup: [drive] [cable 1] [cable 2 + terminal (add a cable and a storage monitor for the dupe item above)] [controller] [powercell] now place a storage cell in the drive and drop an item into the terminal break cable 1, observer storage monitor -> should update immediately to 0 now place the cable 1-> update should take a while since the network is rebuilt now break the cabel 1 again to prepare the initial glitch to execute glitch, place and immediately break the cable again -> the monitor would falsely update on breaking the cable with the items stored in the drive without beeing attached you could then remove the cell from the drive and take out the items and you have duplicated them second setup is similar but you need someone or something to break cable 1 WHILE you are in the terminal! OP did it with a delayline of repeaters that activate an annihilation pane destroying the cable |
Thanks. I'll get some testing setups tonight and report back. |
both were fiexd |
Nice, I'll test the other bugs then. 😎 |
My video:
https://youtu.be/bCB58sHRXxU
or
https://www.youtube.com/watch?v=bCB58sHRXxU&feature=youtu.be
The text was updated successfully, but these errors were encountered: