Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2750: Added missing RF Integration Modules. #2770

Merged
merged 4 commits into from Jan 31, 2017
Merged

Fixes #2750: Added missing RF Integration Modules. #2770

merged 4 commits into from Jan 31, 2017

Conversation

yueh
Copy link
Member

@yueh yueh commented Jan 27, 2017

Readded the integration modules for both RF integrations.
These are necessary to correctly enable RF support as well as act as fallback to disable it automatically on missing interfaces.
Removed superfluous integration types.


public class RFItemModule implements IIntegrationModule
{
public RFItemModule()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Hide this public constructor. rule


public class RFTileModule implements IIntegrationModule
{
public RFTileModule()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Hide this public constructor. rule

Readded the integration modules for both RF integrations.
These are necessary to correctly enable RF support as well as act as
fallback to disable it automatically on missing interfaces.
Added a unittest to ensure an integration types instaniates an integration
module without throwing any exception.
Improved the logging should this ever happen at runtime again.
@orod-org
Copy link

SonarQube analysis reported 2 issues

  • MAJOR 2 major

Watch the comments in this conversation to review them.

@yueh yueh merged commit 12b0527 into master Jan 31, 2017
@yueh yueh deleted the fix-2750 branch January 31, 2017 11:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants