Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain recipes no longer working as of Forge 1.12.2-14.23.0.2532 #3200

Closed
ruifung opened this issue Nov 8, 2017 · 18 comments
Closed

Certain recipes no longer working as of Forge 1.12.2-14.23.0.2532 #3200

ruifung opened this issue Nov 8, 2017 · 18 comments
Assignees

Comments

@ruifung
Copy link
Contributor

@ruifung ruifung commented Nov 8, 2017

As of Forge 14.23.0.2532, probably due to the changes in how ShapelessRecipes are handled,
certain crafting recipes in AE2 are broken, such as the ones for fluix glass cables.

By broken, I mean that the result doesn't even show up in the inventory's 2x2 crafting grid, despite the recipe being correct.

I have tested in forge 14.23.0.2531, and it does not have the issue.

As I am unfamiliar with how recipes are handled, it could also be an issue with the Forge changes.
Therefore, I'm leaving this issue just to notify about the potential breakage.

  • Minecraft Version:
  • AE2 Version: rv5-stable-1
  • Forge Version: 1.12.2-14.23.0.2532
@ruifung
Copy link
Contributor Author

@ruifung ruifung commented Nov 8, 2017

Also on another offtopic note, what a nice issue number.

@fscan
Copy link
Member

@fscan fscan commented Nov 8, 2017

I am unable to reproduce. Can you test with just AE2?

@ruifung
Copy link
Contributor Author

@ruifung ruifung commented Nov 8, 2017

Tested with only AE2 and NEI. (Multiplayer Server), Doesn't seem to work.

Interesting to note that it only happens on a multiplayer server though. So it's most likely a forge issue?

image

@fscan
Copy link
Member

@fscan fscan commented Nov 8, 2017

Hmm ...ok, i tested only locally. The server is running the same forge version?
I'll have to test, this is strange.

@ruifung
Copy link
Contributor Author

@ruifung ruifung commented Nov 9, 2017

Yes, the server is running the same forge version. This is a fresh world, fresh install with only AE2, CoreChickenLib, NEI, JEI... and that's just about it.

@p455w0rd
Copy link

@p455w0rd p455w0rd commented Nov 9, 2017

Related to MinecraftForge/MinecraftForge#4472 ? This is very odd as even @grum approved the changes made in the Forge PR that supposedly fixed this? Specifically here: https://github.com/MinecraftForge/MinecraftForge/pull/4472/files#r146108157 they talk about sidedness..this is supposed to be fixed lol

@SnowShock35
Copy link

@SnowShock35 SnowShock35 commented Nov 9, 2017

@p455w0rd I see you also stumbled on this. Currently having the same issue with dw20 pack too.

@SnowShock35
Copy link

@SnowShock35 SnowShock35 commented Nov 9, 2017

E.g. this recipe should be grout. Nope! it's flint. https://ss.blamesnow.co.uk/2017/11/1510256741-28caf578.png (╯°□°)╯︵ ┻━┻

@fscan
Copy link
Member

@fscan fscan commented Nov 9, 2017

I haven't had the time to look at it yet, but i think we do override the recipe factory for parts. Maybe there is some sidedness issue we introduce with this.

@fscan fscan self-assigned this Nov 10, 2017
@yueh
Copy link
Member

@yueh yueh commented Nov 10, 2017

Cannot reproduce it with neither 2532 nor 2537.

And with NEI being one of the worst offenders in relation to JEI and probably recipes in general, I would not be surprised should it be an issue. Also it fails the "can you reproduce it with just AE2?"

@Skyler-Altol
Copy link

@Skyler-Altol Skyler-Altol commented Nov 11, 2017

Confirmed that this is also occurring in the ATM3 modpack, after upgrading to pack version 4.5. ATM3 doesn't have NEI installed, but it does have JEI installed.

I'll attempt to reproduce this with AE2 and Forge in a standard installation.

Also on another note, it appears this issue affects a fair number of shapeless recipes added by AE2. Cable Anchors are also uncraftable.

@cjburkey01
Copy link

@cjburkey01 cjburkey01 commented Nov 11, 2017

Occurs on a custom pack I play with my friend. Using AE2 rv5-beta-3 and Forge 14.23.0.2537 with a Multiplayer server. Sometimes it looks like the recipe is craftable, but upon crafting the item is not received and a ghost recipe remains in the crafting table.

@ruifung
Copy link
Contributor Author

@ruifung ruifung commented Nov 11, 2017

@yueh In this case, reproduced using only AE2, no other mod, no JEI, NEI, etc. On a multiplayer server instance with, as stated, only AE2.
Works fine when testing in a single player world.

image

@fscan fscan closed this in #3207 Nov 11, 2017
fscan added a commit that referenced this issue Nov 11, 2017
Fixes #3200
@phit
Copy link

@phit phit commented Nov 11, 2017

thanks @fscan 😃

@AgentA1cr
Copy link

@AgentA1cr AgentA1cr commented Nov 12, 2017

I'm currently using rv5-stable-2, and cable anchors still appear to be uncraftable unless using a full durability quartz cutting knife.

@fscan
Copy link
Member

@fscan fscan commented Nov 17, 2017

i'm reopening this until this is fixed in forge

@fscan fscan reopened this Nov 17, 2017
@fscan
Copy link
Member

@fscan fscan commented Nov 18, 2017

@fscan fscan closed this Nov 18, 2017
@ThaUnknown
Copy link

@ThaUnknown ThaUnknown commented Jan 27, 2018

seems to happen again, using forge 1.12.2-14.23.1.2601

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants
You can’t perform that action at this time.