Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern terminal can void patterns #5513

Closed
Mari023 opened this issue Oct 11, 2021 · 1 comment
Closed

Pattern terminal can void patterns #5513

Mari023 opened this issue Oct 11, 2021 · 1 comment
Labels
bug Self explanatory?

Comments

@Mari023
Copy link
Contributor

Mari023 commented Oct 11, 2021

Describe the bug

  1. if you create a pattern in processing mode without an item in the upper left input slot, no pattern will be created but a blank pattern will be used
  2. if you try to create a pattern without an item in the primary output slot, the game will crash
    (this is my bug, the "wired" pattern terminal will just not create a pattern as (probably) intended)
    I just tested it wrong, the "wired" pattern terminal WILL crash to.

How to reproduce the bug

This is a bit tricky due to #5512

  1. a) place at least one item in any one of the input slots, but not the top left slot.
    b) try to create a pattern
    c) the blank pattern will be used, but no pattern will be created
  2. a) place an item in a secondary output slot, but not the primary slot
    b) place an item in the top left input slot (to avoid 1.)
    c) create a pattern
    d) it looks like a pattern is produced, but then the game crashes

Expected behavior

  1. It should just create the pattern like it had in previous versions
  2. this is a bit more complicated due to the mechanics having changed, but in any case, instead of crashing it should just not create a pattern

Additional details

Which minecraft version are you using?

1.17

On which mod loaders does it happen?

Fabric

Crash log

old crash log (ae2wtlib): https://gist.github.com/Mari023/12f8cd7e0fcadcaad0358e511dd0df0e
new crash log (just ae2): https://gist.github.com/Mari023/4c6dd55c461b1ac378f44dca09923eee

@Mari023 Mari023 added the bug Self explanatory? label Oct 11, 2021
@Mari023 Mari023 changed the title Pattern terminal (probably) can void patterns Pattern terminal can void patterns Oct 11, 2021
shartte added a commit that referenced this issue Oct 11, 2021
Fixes #5513: Fix check for primary output being set. Fix check for inputs being set.
@shartte
Copy link
Member

shartte commented Oct 11, 2021

Will be fixed in 9.0.0-alpha.3

@shartte shartte closed this as completed Oct 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

2 participants