Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Terminal Search Modes #5825

Closed
shartte opened this issue Dec 19, 2021 · 0 comments · Fixed by #5844
Closed

Improve Terminal Search Modes #5825

shartte opened this issue Dec 19, 2021 · 0 comments · Fixed by #5844
Labels
feature A suggestion for a completely new feature

Comments

@shartte
Copy link
Member

shartte commented Dec 19, 2021

When enabling JEI/REI synchronized search, it's very confusing which text field now has priority since there are two search boxes simultaneously. We could instead hide the AE2 search box if JEI/REI synchronized search mode is used and simply use the text entered in REI/JEI's own search box for filtering the terminal. It's easy to implement and makes it clearer which search field is to be used.

In this case, the "auto" version of the JEI/REI seach box should also be re-considered. Auto-Focus might be better left to JEI/REI themselves.

Additionally the tooltip of the search mode buttons should be expanded upon to explain that "Auto" refers to auto-focusing the search textfield whenever the terminal is opened.

@shartte shartte added the feature A suggestion for a completely new feature label Dec 19, 2021
@shartte shartte added this to the 10.0.0-alpha - 1.18 milestone Dec 19, 2021
shartte added a commit that referenced this issue Dec 21, 2021
… Order), as well as changes to how REI/JEI synchronized search works. There is now only one REI/JEI search mode and in that mode the AE search box is hidden because the REI/JEI search box is used directly.
shartte added a commit that referenced this issue Dec 21, 2021
… Order), as well as changes to how REI/JEI synchronized search works. There is now only one REI/JEI search mode and in that mode the AE search box is hidden because the REI/JEI search box is used directly.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A suggestion for a completely new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant